Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-lint
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-lint
Commits
0fc104c1
Commit
0fc104c1
authored
Nov 03, 2016
by
Ned Batchelder
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Simplify and robustify the tests
parent
60972b95
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
11 additions
and
24 deletions
+11
-24
test/test_required_base_class.py
+11
-24
No files found.
test/test_required_base_class.py
View file @
0fc104c1
...
...
@@ -11,54 +11,41 @@ class RequiredBaseClassTestCase(CheckerTestCase):
CHECKER_CLASS
=
RequiredBaseClassChecker
def
get_class_node
(
self
,
code
):
"""Parse `code`, and return the last class node.
The code should have at least one class definition.
"""
node
=
astroid
.
parse
(
code
)
class_node
=
None
for
body_node
in
node
.
body
:
if
getattr
(
body_node
,
'type'
,
'none'
)
==
"class"
:
class_node
=
body_node
return
class_node
def
test_no_messages_by_default
(
self
):
node
=
self
.
get_class_nod
e
(
'''
node
=
astroid
.
pars
e
(
'''
class MyClass(object):
pass
'''
)
with
self
.
assertNoMessages
():
self
.
checker
.
visit_class
(
node
)
self
.
walk
(
node
)
@set_config
(
required_base_class
=
[
"BaseClass:MyMixin"
])
def
test_no_messages_if_class_not_used
(
self
):
node
=
self
.
get_class_nod
e
(
'''
node
=
astroid
.
pars
e
(
'''
class MyClass(object):
pass
'''
)
with
self
.
assertNoMessages
():
self
.
checker
.
visit_class
(
node
)
self
.
walk
(
node
)
@set_config
(
required_base_class
=
[
"unittest.case.TestCase:.MyTestMixin"
])
def
test_error_if_class_is_not_used
(
self
):
node
=
self
.
get_class_nod
e
(
'''
node
=
astroid
.
pars
e
(
'''
from unittest import TestCase
class MyClass(TestCase):
pass
'''
)
expected_msg
=
Message
(
'missing-required-base-class'
,
node
=
node
,
node
=
node
.
body
[
-
1
]
,
args
=
(
'MyClass'
,
'.MyTestMixin'
),
)
with
self
.
assertAddsMessages
(
expected_msg
):
self
.
checker
.
visit_class
(
node
)
self
.
walk
(
node
)
@set_config
(
required_base_class
=
[
"unittest.case.TestCase:.MyTestMixin"
])
def
test_no_messages_if_class_is_used
(
self
):
node
=
self
.
get_class_nod
e
(
'''
node
=
astroid
.
pars
e
(
'''
from unittest import TestCase
class MyTestMixin(object):
pass
...
...
@@ -66,15 +53,15 @@ class RequiredBaseClassTestCase(CheckerTestCase):
pass
'''
)
with
self
.
assertNoMessages
():
self
.
checker
.
visit_class
(
node
)
self
.
walk
(
node
)
@set_config
(
required_base_class
=
[
"unittest.case.TestCase:.MyTestMixin"
])
def
test_old_style_classes
(
self
):
# We don't support base class checking on old-style classes, but we
# have to be sure not to fall over at least.
node
=
self
.
get_class_nod
e
(
'''
node
=
astroid
.
pars
e
(
'''
class MyClass:
pass
'''
)
with
self
.
assertNoMessages
():
self
.
checker
.
visit_class
(
node
)
self
.
walk
(
node
)
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment