Address PR comments

analytics_data_api/v0/tests/views/test_courses.py

@@ -142,10 +142,18 @@ class CourseViewTestCaseMixin(DemoCourseMixin):
         self.assertEquals(response.status_code, 404)
 
         # If data falls in date range, data should be returned
-        start_date = start_date.strftime(settings.DATETIME_FORMAT)
-        end_date = end_date.strftime(settings.DATETIME_FORMAT)
+        start = start_date.strftime(settings.DATETIME_FORMAT)
+        end = end_date.strftime(settings.DATETIME_FORMAT)
         response = self.authenticated_get('%scourses/%s%s?start_date=%s&end_date=%s' % (
-            self.api_root_path, self.course_id, self.path, start_date, end_date))
+            self.api_root_path, self.course_id, self.path, start, end))
+        self.assertEquals(response.status_code, 200)
+        self.assertListEqual(response.data, expected_response)
+
+        # Passing dates in DATE_FORMAT still works
+        start = start_date.strftime(settings.DATE_FORMAT)
+        end = end_date.strftime(settings.DATE_FORMAT)
+        response = self.authenticated_get('%scourses/%s%s?start_date=%s&end_date=%s' % (
+            self.api_root_path, self.course_id, self.path, start, end))
         self.assertEquals(response.status_code, 200)
         self.assertListEqual(response.data, expected_response)
 

analytics_data_api/v0/views/courses.py

@@ -29,24 +29,19 @@ class BaseCourseView(generics.ListAPIView):
         end_date = request.QUERY_PARAMS.get('end_date')
         timezone = utc
 
-        if start_date:
-            try:
-                start_date = datetime.datetime.strptime(start_date, settings.DATETIME_FORMAT)
-            except ValueError:
-                start_date = datetime.datetime.strptime(start_date, settings.DATE_FORMAT)
-            start_date = make_aware(start_date, timezone)
+        self.start_date = self.parse_date(start_date, timezone)
+        self.end_date = self.parse_date(end_date, timezone)
+
+        return super(BaseCourseView, self).get(request, *args, **kwargs)
 
-        if end_date:
+    def parse_date(self, date, timezone):
+        if date:
             try:
-                end_date = datetime.datetime.strptime(end_date, settings.DATETIME_FORMAT)
+                date = datetime.datetime.strptime(date, settings.DATETIME_FORMAT)
             except ValueError:
-                end_date = datetime.datetime.strptime(end_date, settings.DATE_FORMAT)
-            end_date = make_aware(end_date, timezone)
-
-        self.start_date = start_date
-        self.end_date = end_date
-
-        return super(BaseCourseView, self).get(request, *args, **kwargs)
+                date = datetime.datetime.strptime(date, settings.DATE_FORMAT)
+            date = make_aware(date, timezone)
+        return date
 
     def apply_date_filtering(self, queryset):
         raise NotImplementedError