Merge pull request #274 from edx/dsjen/display-table-hyphens

Replace zeros with hyphens in the performance pages.

analytics_dashboard/static/js/performance-answer-distribution-main.js

@@ -64,7 +64,8 @@ require(['vendor/domReady!', 'load/init-page'], function(doc, page) {
                     model: courseModel,
                     modelAttribute: 'answerDistribution',
                     columns: tableColumns,
-                    sorting: ['-count']
+                    sorting: ['-count'],
+                    replaceZero: '-'
                 });
 
             });

analytics_dashboard/static/js/performance-graded-content-assignment-main.js

@@ -59,7 +59,8 @@ require(['vendor/domReady!', 'load/init-page'], function (doc, page) {
                 model: model,
                 modelAttribute: 'problems',
                 columns: tableColumns,
-                sorting: ['index']
+                sorting: ['index'],
+                replaceZero: '-'
             });
         });
 });

analytics_dashboard/static/js/performance-graded-content-assignment-types-main.js

@@ -70,7 +70,8 @@ require(['vendor/domReady!', 'load/init-page'], function (doc, page) {
                 model: model,
                 modelAttribute: 'assignments',
                 columns: tableColumns,
-                sorting: ['index']
+                sorting: ['index'],
+                replaceZero: '-'
             });
         });
 });

analytics_dashboard/static/js/test/specs/data-table-view-spec.js

@@ -108,11 +108,15 @@ define(['models/course-model', 'views/data-table-view'], function(CourseModel, D
                 view = new DataTableView({
                     el: document.createElement('div'),
                     model: model,
-                    modelAttribute: 'ages'
+                    modelAttribute: 'ages',
+                    replaceZero: '-'
                 }),
                 func = view.createFormatNumberFunc(dataType),
                 row = {};
 
+            row[dataType] = 0;
+            expect(func(row, renderType)).toBe('-');
+
             row[dataType] = 3;
             expect(func(row, renderType)).toBe('3');
 

analytics_dashboard/static/js/views/data-table-view.js

@@ -98,11 +98,14 @@ define(['dataTablesBootstrap', 'jquery', 'naturalSort', 'underscore', 'utils/uti
              * numbers.
              */
             createFormatNumberFunc: function (columnKey) {
+                var self = this;
                 return function (row, type) {
                     var value = row[columnKey],
                         display = value;
                     if (type === 'display') {
-                        if (!_(value).isUndefined() && !_(value).isNull()){
+                        if (_(self.options).has('replaceZero') && value === 0) {
+                            display = self.options.replaceZero;
+                        } else if (!_(value).isUndefined() && !_(value).isNull()){
                             display = Utils.localizeNumber(Number(value));
                         }
                     }