Upgraded pylint to 1.5.0, fixed linting errors, removed obsolete settings.

acceptance_tests/mixins.py

@@ -372,12 +372,13 @@ class CourseDemographicsPageTestsMixin(CoursePageTestsMixin):
         self.fulfill_loading_promise(self.chart_selector)
         self.assertElementHasContent(self.chart_selector)
 
+    # pylint: disable=unsubscriptable-object
     def _test_table(self):
         self.assertTable(self.table_section_selector, self.table_columns, self.table_download_selector)
 
         rows = self.page.browser.find_elements_by_css_selector('{} tbody tr'.format(self.table_section_selector))
         self.assertGreater(len(rows), 0)
-        sum_count = 0
+        sum_count = 0.0
         if self.demographic_data and 'count' in self.demographic_data[0]:
             sum_count = float(sum([datum['count'] for datum in self.demographic_data]))
 

acceptance_tests/test_course_performance.py

@@ -353,7 +353,7 @@ class CoursePerformanceAnswerDistributionMixin(CoursePerformancePageTestsMixin):
                 actual.append(col.text)
 
             expected = [answer[value_field] if answer[value_field] else u'(empty)']
-            correct = '-'
+            correct = u'-'
             if answer['correct']:
                 correct = u'Correct'
             expected.append(correct)

analytics_dashboard/core/apps.py

+import re
+
 from django.apps import AppConfig
 from django.conf import settings
-import re
 
 
 class AnalyticsDashboardConfig(AppConfig):

analytics_dashboard/core/middleware.py

@@ -28,6 +28,6 @@ class ServiceUnavailableExceptionMiddleware(object):
     """
 
     def process_exception(self, request, exception):
-        if type(exception) is ServiceUnavailableError:
+        if isinstance(exception, ServiceUnavailableError):
             logger.exception(exception)
             return TemplateResponse(request, '503.html', status=503)

analytics_dashboard/core/tests/test_utils.py

-from ddt import data, ddt, unpack
 import uuid
 
+from ddt import data, ddt, unpack
+
 from django.conf import settings
 from django.contrib.auth import get_user_model
 from django.test.utils import override_settings

analytics_dashboard/core/tests/test_views.py

@@ -4,17 +4,19 @@ import logging
 import datetime
 from testfixtures import LogCapture
 
-from django.core.cache import cache
-from django.test.utils import override_settings
 import httpretty
 import jwt
 import mock
+
+from django.core.cache import cache
+from django.core.urlresolvers import reverse, reverse_lazy
 from django.conf import settings
 from django.contrib.auth import get_user_model
 from django.db import DatabaseError
-from django_dynamic_fixture import G
-from django.core.urlresolvers import reverse, reverse_lazy
 from django.test import TestCase
+from django.test.utils import override_settings
+from django_dynamic_fixture import G
+
 from analyticsclient.exceptions import TimeoutError
 from social.exceptions import AuthException
 from social.utils import parse_qs

analytics_dashboard/courses/middleware.py

@@ -34,6 +34,6 @@ class CoursePermissionsExceptionMiddleware(object):
     """
 
     def process_exception(self, request, exception):
-        if type(exception) is PermissionsRetrievalFailedError:
+        if isinstance(exception, PermissionsRetrievalFailedError):
             logger.exception(exception)
             return TemplateResponse(request, 'courses/permissions-retrieval-failed.html', status=500)

analytics_dashboard/courses/permissions.py

@@ -103,7 +103,7 @@ def _get_user_courses(access_token, backend):
     for claim in claims:
         courses.update(data.get(claim, []))
 
-    return courses
+    return list(courses)
 
 
 def get_user_course_permissions(user):

analytics_dashboard/courses/presenters/engagement.py

 import datetime
+import logging
 import math
+
 from django.core.urlresolvers import reverse
 from django.utils.translation import ugettext_lazy as _
-import logging
 from waffle import switch_is_active
 
 from analyticsclient.client import Client

analytics_dashboard/courses/presenters/performance.py

@@ -98,6 +98,7 @@ class CoursePerformancePresenter(CourseAPIPresenterMixin, BasePresenter):
                 return True
         return False
 
+    # pylint: disable=redefined-variable-type
     def _build_questions(self, answer_distributions):
         """
         Builds the questions and part_id from the answer distribution. Displayed

analytics_dashboard/courses/tests/factories.py

-from slugify import slugify
 import urllib
 import uuid
 
+from slugify import slugify
+
 from common.tests.factories import CourseStructureFactory
 from courses.tests.utils import CREATED_DATETIME_STRING
 
@@ -25,7 +26,7 @@ class CoursePerformanceDataFactory(CourseStructureFactory):
                 part_id = '{}_1_2'.format(_id)
                 correct_percent = 1.0
                 if problem_index == 0:
-                    correct_percent = 0
+                    correct_percent = 0.0
                 url_template = '/courses/{}/performance/graded_content/assignments/{}/problems/' \
                                '{}/parts/{}/answer_distribution/'
                 problems.append({

analytics_dashboard/courses/tests/test_middleware.py

-import ddt
 import logging
 
+import ddt
 from django.template.response import TemplateResponse
 from opaque_keys.edx.keys import CourseKey
 from testfixtures import LogCapture

analytics_dashboard/courses/views/__init__.py

 import copy
+from datetime import datetime
 import json
 import logging
 import re
 
 from braces.views import LoginRequiredMixin
 from ccx_keys.locator import CCXLocator
-from datetime import datetime
 from django.conf import settings
 from django.core.cache import cache
 from django.core.exceptions import PermissionDenied
@@ -518,6 +518,7 @@ class CourseHome(CourseTemplateWithNavView):
 
         return items
 
+    # pylint: disable=redefined-variable-type
     def get_context_data(self, **kwargs):
         context = super(CourseHome, self).get_context_data(**kwargs)
         context.update({
@@ -598,8 +599,8 @@ class CourseIndex(CourseAPIMixin, LoginRequiredMixin, TrackedViewMixin, LazyEnco
             # The user is probably not a course administrator and should not be using this application.
             raise PermissionDenied
 
-        courses = self._create_course_list(courses)
-        context['courses'] = courses
+        courses_list = self._create_course_list(courses)
+        context['courses'] = courses_list
         context['page_data'] = self.get_page_data(context)
 
         return context

analytics_dashboard/urls.py

@@ -46,7 +46,7 @@ if settings.DEBUG:  # pragma: no cover
     )
 
     if os.environ.get('ENABLE_DJANGO_TOOLBAR', False):
-        import debug_toolbar  # pylint: disable=import-error
+        import debug_toolbar  # pylint: disable=import-error, wrong-import-position, wrong-import-order
 
         urlpatterns += patterns(
             '',

pylintrc

@@ -7,9 +7,6 @@
 # pygtk.require().
 #init-hook=''
 
-# Profiled execution.
-profile=no
-
 # Add files or directories to the blacklist. They should be base names, not
 # paths.
 ignore=CVS, migrations, settings, wsgi.py
@@ -90,10 +87,6 @@ reports=no
 # (RP0004).
 evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10)
 
-# Add a comment according to your evaluation note. This is used by the global
-# evaluation report (RP0004).
-comment=no
-
 
 [TYPECHECK]
 
@@ -105,10 +98,6 @@ ignore-mixin-members=yes
 # (useful for classes with attributes dynamically set).
 ignored-classes=SQLObject
 
-# When zope mode is activated, add a predefined set of Zope acquired attributes
-# to generated-members.
-zope=no
-
 # List of members which are set dynamically and missed by pylint inference
 # system, and so shouldn't trigger E0201 when accessed. Python regular
 # expressions are accepted.
@@ -130,9 +119,6 @@ generated-members=
 
 [BASIC]
 
-# Required attributes for module, separated by a comma
-required-attributes=
-
 # List of builtins function names that should not be used, separated by a comma
 bad-functions=map,filter,apply,input
 
@@ -274,10 +260,6 @@ max-public-methods=20
 
 [CLASSES]
 
-# List of interface methods to ignore, separated by a comma. This is used for
-# instance to not check methods defines in Zope's Interface base class.
-ignore-iface-methods=isImplementedBy,deferred,extends,names,namesAndDescriptions,queryDescriptionFor,getBases,getDescriptionFor,getDoc,getName,getTaggedValue,getTaggedValueTags,isEqualOrExtendedBy,setTaggedValue,isImplementedByInstancesOf,adaptWith,is_implemented_by
-
 # List of method names used to declare (i.e. assign) instance attributes.
 defining-attr-methods=__init__,__new__,setUp
 

requirements/test.txt

@@ -14,7 +14,7 @@ nose-ignore-docstring==0.2
 nose==1.3.4
 pep257==0.4.1
 pep8==1.6.0
-pylint==1.4.1
+pylint==1.5.0
 logilab-common==0.61.0
 selenium>=2.44.0
 sure==1.2.7