Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
ecommerce
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
ecommerce
Commits
98a327b3
Commit
98a327b3
authored
Dec 19, 2016
by
Michael Frey
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Strip out quotes from course title as they cause a Cybersource error.
parent
ea0c0d8a
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
1 deletions
+17
-1
ecommerce/extensions/payment/processors/cybersource.py
+1
-1
ecommerce/extensions/payment/tests/processors/test_cybersource.py
+16
-0
No files found.
ecommerce/extensions/payment/processors/cybersource.py
View file @
98a327b3
...
...
@@ -171,7 +171,7 @@ class Cybersource(BasePaymentProcessor):
parameters
[
'item_{}_discount_amount '
.
format
(
index
)]
=
str
(
line
.
discount_value
)
# Note (CCB): This indicates that the total_amount field below includes tax.
parameters
[
'item_{}_gross_net_indicator'
.
format
(
index
)]
=
'Y'
parameters
[
'item_{}_name'
.
format
(
index
)]
=
line
.
product
.
title
parameters
[
'item_{}_name'
.
format
(
index
)]
=
line
.
product
.
title
.
replace
(
'"'
,
''
)
parameters
[
'item_{}_quantity'
.
format
(
index
)]
=
line
.
quantity
parameters
[
'item_{}_sku'
.
format
(
index
)]
=
line
.
stockrecord
.
partner_sku
parameters
[
'item_{}_tax_amount'
.
format
(
index
)]
=
str
(
line
.
line_tax
)
...
...
ecommerce/extensions/payment/tests/processors/test_cybersource.py
View file @
98a327b3
...
...
@@ -12,7 +12,9 @@ from django.conf import settings
from
django.test
import
override_settings
from
freezegun
import
freeze_time
from
oscar.apps.payment.exceptions
import
UserCancelled
,
TransactionDeclined
,
GatewayError
from
oscar.test
import
factories
from
ecommerce.courses.tests.factories
import
CourseFactory
from
ecommerce.extensions.payment.exceptions
import
(
InvalidSignatureError
,
InvalidCybersourceDecision
,
PartialAuthorizationError
,
PCIViolation
,
ProcessorMisconfiguredError
...
...
@@ -79,6 +81,20 @@ class CybersourceTests(CybersourceMixin, PaymentProcessorTestCaseMixin, TestCase
extra_parameters
=
{
'payment_method'
:
'card'
}
self
.
assert_correct_transaction_parameters
(
extra_parameters
=
extra_parameters
)
def
test_get_transaction_parameters_with_quoted_product_title
(
self
):
""" Verify quotes are removed from item name """
course
=
CourseFactory
(
id
=
'a/b/c/d'
,
name
=
'Course with "quotes"'
)
product
=
course
.
create_or_update_seat
(
self
.
CERTIFICATE_TYPE
,
False
,
20
,
self
.
partner
)
basket
=
factories
.
create_basket
(
empty
=
True
)
basket
.
add_product
(
product
)
basket
.
owner
=
factories
.
UserFactory
()
basket
.
site
=
self
.
site
basket
.
save
()
response
=
self
.
processor
.
get_transaction_parameters
(
basket
)
self
.
assertEqual
(
response
[
'item_0_name'
],
'Seat in Course with quotes with test-certificate-type certificate'
)
@ddt.data
(
'card_type'
,
'card_number'
,
'card_expiry_date'
,
'card_cvn'
)
def
test_get_transaction_parameters_with_unpermitted_parameters
(
self
,
field
):
""" Verify the method raises an error if un-permitted parameters are passed to the method. """
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment