Merge pull request #125 from edx/jsa/xcom-317

Send product.title instead of course key in segment events.

ecommerce/extensions/checkout/signals.py

@@ -28,7 +28,7 @@ def track_completed_order(sender, order=None, **kwargs):  # pylint: disable=unus
                 {
                     'id': line.upc,
                     'sku': line.partner_sku,
-                    'name': line.product.attr.course_key,
+                    'name': line.product.title,
                     'price': str(line.line_price_excl_tax),
                     'quantity': line.quantity,
                     'category': line.product.get_product_class().name,

ecommerce/extensions/checkout/tests/test_signals.py

@@ -39,7 +39,7 @@ class EdxOrderPlacementMixinTests(BusinessIntelligenceMixin, TestCase):
             structure='child',
             parent=parent_product,
         )
-        child_product.attr.course_key = 'test-course-key'
+        child_product.attr.course_key = 'dummy-course-key'
         child_product.save()
 
         # create test user and set up basket / order

ecommerce/extensions/refund/signals.py

@@ -31,7 +31,7 @@ def track_completed_refund(sender, refund=None, **kwargs):  # pylint: disable=un
                 {
                     'id': line.order_line.upc,
                     'sku': line.order_line.partner_sku,
-                    'name': line.order_line.product.attr.course_key,
+                    'name': line.order_line.product.title,
                     'price': str(line.line_credit_excl_tax),
                     'quantity': -1 * line.quantity,
                     'category': line.order_line.product.get_product_class().name,

ecommerce/tests/mixins.py

@@ -180,7 +180,7 @@ class BusinessIntelligenceMixin(object):
             for line in lines:
                 tracked_product = tracked_products_dict.get(line.partner_sku)
                 self.assertIsNotNone(tracked_product)
-                self.assertEqual(line.product.attr.course_key, tracked_product['name'])
+                self.assertEqual(line.product.title, tracked_product['name'])
                 self.assertEqual(str(line.line_price_excl_tax), tracked_product['price'])
                 self.assertEqual(line.quantity, tracked_product['quantity'])
                 self.assertEqual(line.product.get_product_class().name, tracked_product['category'])
@@ -190,7 +190,7 @@ class BusinessIntelligenceMixin(object):
             for line in lines:
                 tracked_product = tracked_products_dict.get(line.order_line.partner_sku)
                 self.assertIsNotNone(tracked_product)
-                self.assertEqual(line.order_line.product.attr.course_key, tracked_product['name'])
+                self.assertEqual(line.order_line.product.title, tracked_product['name'])
                 self.assertEqual(str(line.line_credit_excl_tax), tracked_product['price'])
                 self.assertEqual(-1 * line.quantity, tracked_product['quantity'])
                 self.assertEqual(line.order_line.product.get_product_class().name, tracked_product['category'])