Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
fb423373
Commit
fb423373
authored
Jul 02, 2015
by
Tom Christie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Empty settings should also be coerced to lists. Closes #3087.
parent
a03b89f3
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
1 deletions
+14
-1
rest_framework/settings.py
+1
-1
tests/test_settings.py
+13
-0
No files found.
rest_framework/settings.py
View file @
fb423373
...
@@ -204,7 +204,7 @@ class APISettings(object):
...
@@ -204,7 +204,7 @@ class APISettings(object):
val
=
self
.
defaults
[
attr
]
val
=
self
.
defaults
[
attr
]
# Coerce import strings into classes
# Coerce import strings into classes
if
val
and
attr
in
self
.
import_strings
:
if
attr
in
self
.
import_strings
:
val
=
perform_import
(
val
,
attr
)
val
=
perform_import
(
val
,
attr
)
# Cache the result
# Cache the result
...
...
tests/test_settings.py
View file @
fb423373
...
@@ -17,3 +17,16 @@ class TestSettings(TestCase):
...
@@ -17,3 +17,16 @@ class TestSettings(TestCase):
})
})
with
self
.
assertRaises
(
ImportError
):
with
self
.
assertRaises
(
ImportError
):
settings
.
DEFAULT_RENDERER_CLASSES
settings
.
DEFAULT_RENDERER_CLASSES
class
TestSettingTypes
(
TestCase
):
def
test_settings_consistently_coerced_to_list
(
self
):
settings
=
APISettings
({
'DEFAULT_THROTTLE_CLASSES'
:
(
'rest_framework.throttling.BaseThrottle'
,)
})
self
.
assertTrue
(
isinstance
(
settings
.
DEFAULT_THROTTLE_CLASSES
,
list
))
settings
=
APISettings
({
'DEFAULT_THROTTLE_CLASSES'
:
()
})
self
.
assertTrue
(
isinstance
(
settings
.
DEFAULT_THROTTLE_CLASSES
,
list
))
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment