Commit f27a2868 by Greg Doermann

Frameworks throws AssertionError saying you cannot set required=True and…

Frameworks throws AssertionError saying you cannot set required=True and read_only=True on editable=False model fields.  We should not make the field required if editable=False.
parent 21a0a826
...@@ -831,7 +831,7 @@ class ModelSerializer(Serializer): ...@@ -831,7 +831,7 @@ class ModelSerializer(Serializer):
} }
if model_field: if model_field:
kwargs['required'] = not(model_field.null or model_field.blank) kwargs['required'] = not(model_field.null or model_field.blank) and model_field.editable
if model_field.help_text is not None: if model_field.help_text is not None:
kwargs['help_text'] = model_field.help_text kwargs['help_text'] = model_field.help_text
if model_field.verbose_name is not None: if model_field.verbose_name is not None:
...@@ -854,7 +854,7 @@ class ModelSerializer(Serializer): ...@@ -854,7 +854,7 @@ class ModelSerializer(Serializer):
""" """
kwargs = {} kwargs = {}
if model_field.null or model_field.blank: if model_field.null or model_field.blank and model_field.editable:
kwargs['required'] = False kwargs['required'] = False
if isinstance(model_field, models.AutoField) or not model_field.editable: if isinstance(model_field, models.AutoField) or not model_field.editable:
...@@ -1110,7 +1110,7 @@ class HyperlinkedModelSerializer(ModelSerializer): ...@@ -1110,7 +1110,7 @@ class HyperlinkedModelSerializer(ModelSerializer):
} }
if model_field: if model_field:
kwargs['required'] = not(model_field.null or model_field.blank) kwargs['required'] = not(model_field.null or model_field.blank) and model_field.editable
if model_field.help_text is not None: if model_field.help_text is not None:
kwargs['help_text'] = model_field.help_text kwargs['help_text'] = model_field.help_text
if model_field.verbose_name is not None: if model_field.verbose_name is not None:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment