Commit d1371cc9 by Nicolas Delaby

Use post instead of get for sanity of use-case.

parent c2d24172
...@@ -15,19 +15,19 @@ factory = APIRequestFactory() ...@@ -15,19 +15,19 @@ factory = APIRequestFactory()
class BasicView(APIView): class BasicView(APIView):
def get(self, request, *args, **kwargs): def post(self, request, *args, **kwargs):
BasicModel.objects.create() BasicModel.objects.create()
return Response({'method': 'GET'}) return Response({'method': 'GET'})
class ErrorView(APIView): class ErrorView(APIView):
def get(self, request, *args, **kwargs): def post(self, request, *args, **kwargs):
BasicModel.objects.create() BasicModel.objects.create()
raise Exception raise Exception
class APIExceptionView(APIView): class APIExceptionView(APIView):
def get(self, request, *args, **kwargs): def post(self, request, *args, **kwargs):
BasicModel.objects.create() BasicModel.objects.create()
raise APIException raise APIException
...@@ -43,7 +43,7 @@ class DBTransactionTests(TestCase): ...@@ -43,7 +43,7 @@ class DBTransactionTests(TestCase):
connections.databases['default']['ATOMIC_REQUESTS'] = False connections.databases['default']['ATOMIC_REQUESTS'] = False
def test_no_exception_conmmit_transaction(self): def test_no_exception_conmmit_transaction(self):
request = factory.get('/') request = factory.post('/')
with self.assertNumQueries(1): with self.assertNumQueries(1):
response = self.view(request) response = self.view(request)
...@@ -66,7 +66,7 @@ class DBTransactionErrorTests(TestCase): ...@@ -66,7 +66,7 @@ class DBTransactionErrorTests(TestCase):
Transaction is eventually managed by outer-most transaction atomic Transaction is eventually managed by outer-most transaction atomic
block. DRF do not try to interfere here. block. DRF do not try to interfere here.
""" """
request = factory.get('/') request = factory.post('/')
with self.assertNumQueries(3): with self.assertNumQueries(3):
# 1 - begin savepoint # 1 - begin savepoint
# 2 - insert # 2 - insert
...@@ -90,7 +90,7 @@ class DBTransactionAPIExceptionTests(TestCase): ...@@ -90,7 +90,7 @@ class DBTransactionAPIExceptionTests(TestCase):
""" """
Transaction is rollbacked by our transaction atomic block. Transaction is rollbacked by our transaction atomic block.
""" """
request = factory.get('/') request = factory.post('/')
num_queries = (4 if getattr(connection.features, num_queries = (4 if getattr(connection.features,
'can_release_savepoints', False) else 3) 'can_release_savepoints', False) else 3)
with self.assertNumQueries(num_queries): with self.assertNumQueries(num_queries):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment