Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
d11b5564
Commit
d11b5564
authored
May 29, 2013
by
David Medina
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bugfix: Fix run validation layer with invalid data
parent
85fe7197
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
1 deletions
+15
-1
rest_framework/serializers.py
+2
-1
rest_framework/tests/test_validation.py
+13
-0
No files found.
rest_framework/serializers.py
View file @
d11b5564
...
@@ -315,7 +315,8 @@ class BaseSerializer(WritableField):
...
@@ -315,7 +315,8 @@ class BaseSerializer(WritableField):
self
.
_errors
=
{}
self
.
_errors
=
{}
if
data
is
not
None
or
files
is
not
None
:
if
data
is
not
None
or
files
is
not
None
:
attrs
=
self
.
restore_fields
(
data
,
files
)
attrs
=
self
.
restore_fields
(
data
,
files
)
attrs
=
self
.
perform_validation
(
attrs
)
if
attrs
is
not
None
:
attrs
=
self
.
perform_validation
(
attrs
)
else
:
else
:
self
.
_errors
[
'non_field_errors'
]
=
[
'No input provided'
]
self
.
_errors
[
'non_field_errors'
]
=
[
'No input provided'
]
...
...
rest_framework/tests/test_validation.py
View file @
d11b5564
...
@@ -63,3 +63,16 @@ class TestPreSaveValidationExclusions(TestCase):
...
@@ -63,3 +63,16 @@ class TestPreSaveValidationExclusions(TestCase):
# does not have `blank=True`, so this serializer should not validate.
# does not have `blank=True`, so this serializer should not validate.
serializer
=
ShouldValidateModelSerializer
(
data
=
{
'renamed'
:
''
})
serializer
=
ShouldValidateModelSerializer
(
data
=
{
'renamed'
:
''
})
self
.
assertEqual
(
serializer
.
is_valid
(),
False
)
self
.
assertEqual
(
serializer
.
is_valid
(),
False
)
class
FieldValidationSerializer
(
serializers
.
Serializer
):
foo
=
serializers
.
CharField
()
def
validate_foo
(
self
,
attrs
,
source
):
raise
StandardError
(
"validate_foo was called"
)
class
TestFieldValidationWithInvalidData
(
TestCase
):
def
test_validate_foo_was_not_called
(
self
):
serializer
=
FieldValidationSerializer
(
data
=
'invalid data'
)
self
.
assertFalse
(
serializer
.
is_valid
())
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment