Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
b1c1867b
Commit
b1c1867b
authored
Mar 23, 2015
by
Devon Bleibtrey
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Swapping to hassattr logic for pk attribute references in relations
parent
7ac3c3ff
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
4 deletions
+2
-4
rest_framework/relations.py
+2
-4
No files found.
rest_framework/relations.py
View file @
b1c1867b
...
...
@@ -166,7 +166,6 @@ class HyperlinkedRelatedField(RelatedField):
self
.
lookup_field
=
kwargs
.
pop
(
'lookup_field'
,
self
.
lookup_field
)
self
.
lookup_url_kwarg
=
kwargs
.
pop
(
'lookup_url_kwarg'
,
self
.
lookup_field
)
self
.
format
=
kwargs
.
pop
(
'format'
,
None
)
self
.
id_field
=
kwargs
.
pop
(
'id_field'
,
'pk'
)
# We include this simply for dependency injection in tests.
# We can't add it as a class attributes or it would expect an
...
...
@@ -197,7 +196,7 @@ class HyperlinkedRelatedField(RelatedField):
attributes are not configured to correctly match the URL conf.
"""
# Unsaved objects will not yet have a valid URL.
if
getattr
(
obj
,
self
.
id_field
)
is
None
:
if
hasattr
(
obj
,
'pk'
)
and
obj
.
pk
is
None
:
return
None
lookup_value
=
getattr
(
obj
,
self
.
lookup_field
)
...
...
@@ -341,7 +340,6 @@ class ManyRelatedField(Field):
assert
child_relation
is
not
None
,
'`child_relation` is a required argument.'
super
(
ManyRelatedField
,
self
)
.
__init__
(
*
args
,
**
kwargs
)
self
.
child_relation
.
bind
(
field_name
=
''
,
parent
=
self
)
self
.
id_field
=
kwargs
.
pop
(
'id_field'
,
'pk'
)
def
get_value
(
self
,
dictionary
):
# We override the default field access in order to support
...
...
@@ -363,7 +361,7 @@ class ManyRelatedField(Field):
def
get_attribute
(
self
,
instance
):
# Can't have any relationships if not created
if
getattr
(
instance
,
self
.
id_field
)
is
None
:
if
hasattr
(
instance
,
'pk'
)
and
instance
.
pk
is
None
:
return
[]
relationship
=
get_attribute
(
instance
,
self
.
source_attrs
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment