Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
af686ec1
Commit
af686ec1
authored
Feb 14, 2013
by
Tom Christie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
request.DATA should use empty QueryDict for no data, not None.
parent
9d3153ed
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
6 deletions
+11
-6
rest_framework/request.py
+7
-2
rest_framework/tests/request.py
+4
-4
No files found.
rest_framework/request.py
View file @
af686ec1
...
@@ -11,7 +11,9 @@ The wrapped request then offers a richer API, in particular :
...
@@ -11,7 +11,9 @@ The wrapped request then offers a richer API, in particular :
"""
"""
from
__future__
import
unicode_literals
from
__future__
import
unicode_literals
from
django.conf
import
settings
from
django.conf
import
settings
from
django.http
import
QueryDict
from
django.http.multipartparser
import
parse_header
from
django.http.multipartparser
import
parse_header
from
django.utils.datastructures
import
MultiValueDict
from
rest_framework
import
HTTP_HEADER_ENCODING
from
rest_framework
import
HTTP_HEADER_ENCODING
from
rest_framework
import
exceptions
from
rest_framework
import
exceptions
from
rest_framework.compat
import
BytesIO
from
rest_framework.compat
import
BytesIO
...
@@ -297,7 +299,9 @@ class Request(object):
...
@@ -297,7 +299,9 @@ class Request(object):
media_type
=
self
.
content_type
media_type
=
self
.
content_type
if
stream
is
None
or
media_type
is
None
:
if
stream
is
None
or
media_type
is
None
:
return
(
None
,
None
)
empty_data
=
QueryDict
(
''
,
self
.
_request
.
_encoding
)
empty_files
=
MultiValueDict
()
return
(
empty_data
,
empty_files
)
parser
=
self
.
negotiator
.
select_parser
(
self
,
self
.
parsers
)
parser
=
self
.
negotiator
.
select_parser
(
self
,
self
.
parsers
)
...
@@ -311,7 +315,8 @@ class Request(object):
...
@@ -311,7 +315,8 @@ class Request(object):
try
:
try
:
return
(
parsed
.
data
,
parsed
.
files
)
return
(
parsed
.
data
,
parsed
.
files
)
except
AttributeError
:
except
AttributeError
:
return
(
parsed
,
None
)
empty_files
=
MultiValueDict
()
return
(
parsed
,
empty_files
)
def
_authenticate
(
self
):
def
_authenticate
(
self
):
"""
"""
...
...
rest_framework/tests/request.py
View file @
af686ec1
...
@@ -62,17 +62,17 @@ class TestMethodOverloading(TestCase):
...
@@ -62,17 +62,17 @@ class TestMethodOverloading(TestCase):
class
TestContentParsing
(
TestCase
):
class
TestContentParsing
(
TestCase
):
def
test_standard_behaviour_determines_no_content_GET
(
self
):
def
test_standard_behaviour_determines_no_content_GET
(
self
):
"""
"""
Ensure request.DATA returns
None for GET request with no conten
t.
Ensure request.DATA returns
empty QueryDict for GET reques
t.
"""
"""
request
=
Request
(
factory
.
get
(
'/'
))
request
=
Request
(
factory
.
get
(
'/'
))
self
.
assertEqual
(
request
.
DATA
,
None
)
self
.
assertEqual
(
request
.
DATA
,
{}
)
def
test_standard_behaviour_determines_no_content_HEAD
(
self
):
def
test_standard_behaviour_determines_no_content_HEAD
(
self
):
"""
"""
Ensure request.DATA returns
None
for HEAD request.
Ensure request.DATA returns
empty QueryDict
for HEAD request.
"""
"""
request
=
Request
(
factory
.
head
(
'/'
))
request
=
Request
(
factory
.
head
(
'/'
))
self
.
assertEqual
(
request
.
DATA
,
None
)
self
.
assertEqual
(
request
.
DATA
,
{}
)
def
test_request_DATA_with_form_content
(
self
):
def
test_request_DATA_with_form_content
(
self
):
"""
"""
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment