Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
ad7aa8fe
Commit
ad7aa8fe
authored
Nov 17, 2013
by
Xavier Ordoquy
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed the nested model serializers in case of the related_name isn’t set.
parent
128bda57
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
36 additions
and
1 deletions
+36
-1
rest_framework/serializers.py
+1
-1
rest_framework/tests/test_serializer_nested.py
+35
-0
No files found.
rest_framework/serializers.py
View file @
ad7aa8fe
...
@@ -872,7 +872,7 @@ class ModelSerializer(Serializer):
...
@@ -872,7 +872,7 @@ class ModelSerializer(Serializer):
# Reverse fk or one-to-one relations
# Reverse fk or one-to-one relations
for
(
obj
,
model
)
in
meta
.
get_all_related_objects_with_model
():
for
(
obj
,
model
)
in
meta
.
get_all_related_objects_with_model
():
field_name
=
obj
.
field
.
related_query
_name
()
field_name
=
obj
.
get_accessor
_name
()
if
field_name
in
attrs
:
if
field_name
in
attrs
:
related_data
[
field_name
]
=
attrs
.
pop
(
field_name
)
related_data
[
field_name
]
=
attrs
.
pop
(
field_name
)
...
...
rest_framework/tests/test_serializer_nested.py
View file @
ad7aa8fe
...
@@ -6,6 +6,7 @@ Doesn't cover model serializers.
...
@@ -6,6 +6,7 @@ Doesn't cover model serializers.
from
__future__
import
unicode_literals
from
__future__
import
unicode_literals
from
django.test
import
TestCase
from
django.test
import
TestCase
from
rest_framework
import
serializers
from
rest_framework
import
serializers
from
.
import
models
class
WritableNestedSerializerBasicTests
(
TestCase
):
class
WritableNestedSerializerBasicTests
(
TestCase
):
...
@@ -311,3 +312,37 @@ class ForeignKeyNestedSerializerUpdateTests(TestCase):
...
@@ -311,3 +312,37 @@ class ForeignKeyNestedSerializerUpdateTests(TestCase):
serializer
=
self
.
AlbumSerializer
(
instance
=
original
,
data
=
data
)
serializer
=
self
.
AlbumSerializer
(
instance
=
original
,
data
=
data
)
self
.
assertEqual
(
serializer
.
is_valid
(),
True
)
self
.
assertEqual
(
serializer
.
is_valid
(),
True
)
self
.
assertEqual
(
serializer
.
object
,
expected
)
self
.
assertEqual
(
serializer
.
object
,
expected
)
class
NestedModelSerializerUpdateTests
(
TestCase
):
def
test_second_nested_level
(
self
):
john
=
models
.
Person
.
objects
.
create
(
name
=
"john"
)
post
=
john
.
blogpost_set
.
create
(
title
=
"Test blog post"
)
post
.
blogpostcomment_set
.
create
(
text
=
"I hate this blog post"
)
post
.
blogpostcomment_set
.
create
(
text
=
"I love this blog post"
)
class
BlogPostCommentSerializer
(
serializers
.
ModelSerializer
):
class
Meta
:
model
=
models
.
BlogPostComment
class
BlogPostSerializer
(
serializers
.
ModelSerializer
):
comments
=
BlogPostCommentSerializer
(
many
=
True
,
source
=
'blogpostcomment_set'
)
class
Meta
:
model
=
models
.
BlogPost
fields
=
(
'id'
,
'title'
,
'comments'
)
class
PersonSerializer
(
serializers
.
ModelSerializer
):
posts
=
BlogPostSerializer
(
many
=
True
,
source
=
'blogpost_set'
)
class
Meta
:
model
=
models
.
Person
fields
=
(
'id'
,
'name'
,
'age'
,
'posts'
)
serialize
=
PersonSerializer
(
instance
=
john
)
deserialize
=
PersonSerializer
(
data
=
serialize
.
data
,
instance
=
john
)
self
.
assertTrue
(
deserialize
.
is_valid
())
result
=
deserialize
.
object
result
.
save
()
self
.
assertEqual
(
result
.
id
,
john
.
id
)
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment