Commit a7723261 by Kevin Brown

Merged two DecimalValidator tests together

These two tests were previously added in
https://github.com/tomchristie/django-rest-framework/commit/7d79cf35b7be01b175d8c25276a4414e8144a16b
but we have now discovered that there are not actually two separate
cases, there was just a  bug in the code that made it look that way.

This also removes a redundant check to see if `DecimalValidator` was
defined.
parent d797389c
...@@ -133,7 +133,7 @@ def get_field_kwargs(field_name, model_field): ...@@ -133,7 +133,7 @@ def get_field_kwargs(field_name, model_field):
if isinstance(model_field, models.DecimalField) and DecimalValidator: if isinstance(model_field, models.DecimalField) and DecimalValidator:
validator_kwarg = [ validator_kwarg = [
validator for validator in validator_kwarg validator for validator in validator_kwarg
if DecimalValidator and not isinstance(validator, DecimalValidator) if not isinstance(validator, DecimalValidator)
] ]
# Ensure that max_length is passed explicitly as a keyword arg, # Ensure that max_length is passed explicitly as a keyword arg,
......
...@@ -22,7 +22,7 @@ from django.utils import six ...@@ -22,7 +22,7 @@ from django.utils import six
from rest_framework import serializers from rest_framework import serializers
from rest_framework.compat import DurationField as ModelDurationField from rest_framework.compat import DurationField as ModelDurationField
from rest_framework.compat import DecimalValidator, unicode_repr from rest_framework.compat import unicode_repr
def dedent(blocktext): def dedent(blocktext):
...@@ -872,25 +872,9 @@ class DecimalFieldModel(models.Model): ...@@ -872,25 +872,9 @@ class DecimalFieldModel(models.Model):
class TestDecimalFieldMappings(TestCase): class TestDecimalFieldMappings(TestCase):
@pytest.mark.skipif(DecimalValidator is not None,
reason='DecimalValidator is available in Django 1.9+')
def test_decimal_field_has_no_decimal_validator(self):
"""
Test that a DecimalField has no validators before Django 1.9.
"""
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = DecimalFieldModel
serializer = TestSerializer()
assert len(serializer.fields['decimal_field'].validators) == 2
@pytest.mark.skipif(DecimalValidator is None,
reason='DecimalValidator is available in Django 1.9+')
def test_decimal_field_has_decimal_validator(self): def test_decimal_field_has_decimal_validator(self):
""" """
Test that a DecimalField has DecimalValidator in Django 1.9+. Test that a `DecimalField` has no `DecimalValidator`.
""" """
class TestSerializer(serializers.ModelSerializer): class TestSerializer(serializers.ModelSerializer):
class Meta: class Meta:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment