Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
9cb547b8
Commit
9cb547b8
authored
Feb 20, 2015
by
Rense VanderHoek
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Validator-fix, added min/max fields to test_metadata
parent
c8609ba6
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
6 deletions
+15
-6
rest_framework/fields.py
+2
-2
tests/test_metadata.py
+13
-4
No files found.
rest_framework/fields.py
View file @
9cb547b8
...
...
@@ -738,10 +738,10 @@ class DecimalField(Field):
super
(
DecimalField
,
self
)
.
__init__
(
**
kwargs
)
if
self
.
max_value
is
not
None
:
message
=
self
.
error_messages
[
'max_value'
]
.
format
(
max_value
=
self
.
max_value
)
self
.
validators
.
append
(
MaxValueValidator
(
max_value
,
message
=
message
))
self
.
validators
.
append
(
MaxValueValidator
(
self
.
max_value
,
message
=
message
))
if
self
.
min_value
is
not
None
:
message
=
self
.
error_messages
[
'min_value'
]
.
format
(
min_value
=
self
.
min_value
)
self
.
validators
.
append
(
MinValueValidator
(
min_value
,
message
=
message
))
self
.
validators
.
append
(
MinValueValidator
(
self
.
min_value
,
message
=
message
))
def
to_internal_value
(
self
,
data
):
"""
...
...
tests/test_metadata.py
View file @
9cb547b8
...
...
@@ -54,8 +54,12 @@ class TestMetadata:
"""
class
ExampleSerializer
(
serializers
.
Serializer
):
choice_field
=
serializers
.
ChoiceField
([
'red'
,
'green'
,
'blue'
])
integer_field
=
serializers
.
IntegerField
(
max_value
=
10
)
char_field
=
serializers
.
CharField
(
required
=
False
)
integer_field
=
serializers
.
IntegerField
(
min_value
=
1
,
max_value
=
1000
)
char_field
=
serializers
.
CharField
(
required
=
False
,
min_length
=
3
,
max_length
=
40
)
class
ExampleView
(
views
.
APIView
):
"""Example view."""
...
...
@@ -96,13 +100,18 @@ class TestMetadata:
'type'
:
'integer'
,
'required'
:
True
,
'read_only'
:
False
,
'label'
:
'Integer field'
'label'
:
'Integer field'
,
'min_value'
:
1
,
'max_value'
:
1000
,
},
'char_field'
:
{
'type'
:
'string'
,
'required'
:
False
,
'read_only'
:
False
,
'label'
:
'Char field'
'label'
:
'Char field'
,
'min_length'
:
3
,
'max_length'
:
40
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment