Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
8e84a9f6
Commit
8e84a9f6
authored
May 15, 2015
by
David Sanders
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Allow invalid outputs to pass through to_representation() for ChoiceField & MultipleChoiceField
parent
6add1acc
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
4 deletions
+11
-4
rest_framework/fields.py
+8
-2
tests/test_fields.py
+3
-2
No files found.
rest_framework/fields.py
View file @
8e84a9f6
...
...
@@ -1042,10 +1042,16 @@ class ChoiceField(Field):
except
KeyError
:
self
.
fail
(
'invalid_choice'
,
input
=
data
)
def
representation_value
(
self
,
value
):
try
:
return
self
.
choice_strings_to_values
[
six
.
text_type
(
value
)]
except
KeyError
:
return
value
def
to_representation
(
self
,
value
):
if
value
in
(
''
,
None
):
return
value
return
self
.
choice_strings_to_values
[
six
.
text_type
(
value
)]
return
self
.
representation_value
(
value
)
class
MultipleChoiceField
(
ChoiceField
):
...
...
@@ -1073,7 +1079,7 @@ class MultipleChoiceField(ChoiceField):
def
to_representation
(
self
,
value
):
return
set
([
self
.
choice_strings_to_values
[
six
.
text_type
(
item
)]
for
item
in
value
self
.
representation_value
(
item
)
for
item
in
value
])
...
...
tests/test_fields.py
View file @
8e84a9f6
...
...
@@ -920,7 +920,8 @@ class TestChoiceField(FieldValues):
}
outputs
=
{
'good'
:
'good'
,
''
:
''
''
:
''
,
'amazing'
:
'amazing'
,
}
field
=
serializers
.
ChoiceField
(
choices
=
[
...
...
@@ -1005,7 +1006,7 @@ class TestMultipleChoiceField(FieldValues):
(
'aircon'
,
'incorrect'
):
[
'"incorrect" is not a valid choice.'
]
}
outputs
=
[
([
'aircon'
,
'manual'
],
set
([
'aircon'
,
'manual
'
]))
([
'aircon'
,
'manual'
,
'incorrect'
],
set
([
'aircon'
,
'manual'
,
'incorrect
'
]))
]
field
=
serializers
.
MultipleChoiceField
(
choices
=
[
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment