Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
883efbc1
Commit
883efbc1
authored
Oct 04, 2016
by
Rowan Seymour
Committed by
Tom Christie
Oct 04, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Case insensitive uniqueness validation (#4534)
parent
0b373be7
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
4 deletions
+6
-4
docs/api-guide/validators.md
+1
-0
rest_framework/validators.py
+3
-2
tests/test_validators.py
+2
-2
No files found.
docs/api-guide/validators.md
View file @
883efbc1
...
...
@@ -61,6 +61,7 @@ It takes a single required argument, and an optional `messages` argument:
*
`queryset`
*required*
- This is the queryset against which uniqueness should be enforced.
*
`message`
- The error message that should be used when validation fails.
*
`lookup`
- The lookup used to find an existing instance with the value being validated. Defaults to
`'exact'`
.
This validator should be applied to
*serializer fields*
, like so:
...
...
rest_framework/validators.py
View file @
883efbc1
...
...
@@ -42,10 +42,11 @@ class UniqueValidator(object):
"""
message
=
_
(
'This field must be unique.'
)
def
__init__
(
self
,
queryset
,
message
=
None
):
def
__init__
(
self
,
queryset
,
message
=
None
,
lookup
=
'exact'
):
self
.
queryset
=
queryset
self
.
serializer_field
=
None
self
.
message
=
message
or
self
.
message
self
.
lookup
=
lookup
def
set_context
(
self
,
serializer_field
):
"""
...
...
@@ -62,7 +63,7 @@ class UniqueValidator(object):
"""
Filter the queryset to all instances matching the given attribute.
"""
filter_kwargs
=
{
self
.
field_name
:
value
}
filter_kwargs
=
{
'
%
s__
%
s'
%
(
self
.
field_name
,
self
.
lookup
)
:
value
}
return
qs_filter
(
queryset
,
**
filter_kwargs
)
def
exclude_current_instance
(
self
,
queryset
):
...
...
tests/test_validators.py
View file @
883efbc1
...
...
@@ -31,7 +31,7 @@ class RelatedModel(models.Model):
class
RelatedModelSerializer
(
serializers
.
ModelSerializer
):
username
=
serializers
.
CharField
(
source
=
'user.username'
,
validators
=
[
UniqueValidator
(
queryset
=
UniquenessModel
.
objects
.
all
())])
# NOQA
validators
=
[
UniqueValidator
(
queryset
=
UniquenessModel
.
objects
.
all
()
,
lookup
=
'iexact'
)])
# NOQA
class
Meta
:
model
=
RelatedModel
...
...
@@ -103,7 +103,7 @@ class TestUniquenessValidation(TestCase):
AnotherUniquenessModel
.
_meta
.
get_field
(
'code'
)
.
validators
,
[])
def
test_related_model_is_unique
(
self
):
data
=
{
'username'
:
'
e
xisting'
,
'email'
:
'new-email@example.com'
}
data
=
{
'username'
:
'
E
xisting'
,
'email'
:
'new-email@example.com'
}
rs
=
RelatedModelSerializer
(
data
=
data
)
self
.
assertFalse
(
rs
.
is_valid
())
self
.
assertEqual
(
rs
.
errors
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment