Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
7640bfea
Commit
7640bfea
authored
Sep 22, 2015
by
paolopaolopaolo
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add `assert` statement to `.save()` method in Serializer:
- Asserts that `_data` does not exist when calling `.save()`
parent
134f5fa4
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
0 deletions
+7
-0
rest_framework/serializers.py
+6
-0
tests/test_serializer.py
+1
-0
No files found.
rest_framework/serializers.py
View file @
7640bfea
...
@@ -166,6 +166,12 @@ class BaseSerializer(Field):
...
@@ -166,6 +166,12 @@ class BaseSerializer(Field):
"For example: 'serializer.save(owner=request.user)'.'"
"For example: 'serializer.save(owner=request.user)'.'"
)
)
assert
not
hasattr
(
self
,
'_data'
),
(
"You cannot call `.save()` after accessing `serializer.data`."
"If you need to access data before committing to the database then "
"inspect 'serializer.validated_data' instead. "
)
validated_data
=
dict
(
validated_data
=
dict
(
list
(
self
.
validated_data
.
items
())
+
list
(
self
.
validated_data
.
items
())
+
list
(
kwargs
.
items
())
list
(
kwargs
.
items
())
...
...
tests/test_serializer.py
View file @
7640bfea
...
@@ -61,6 +61,7 @@ class TestSerializer:
...
@@ -61,6 +61,7 @@ class TestSerializer:
with
pytest
.
raises
(
AssertionError
):
with
pytest
.
raises
(
AssertionError
):
serializer
.
save
()
serializer
.
save
()
class
TestValidateMethod
:
class
TestValidateMethod
:
def
test_non_field_error_validate_method
(
self
):
def
test_non_field_error_validate_method
(
self
):
class
ExampleSerializer
(
serializers
.
Serializer
):
class
ExampleSerializer
(
serializers
.
Serializer
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment