Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
743224d0
Commit
743224d0
authored
Nov 08, 2012
by
Tomi Pajunen
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed creation of objects with reversed M2M relations
parent
066d51fa
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
25 additions
and
0 deletions
+25
-0
rest_framework/serializers.py
+7
-0
rest_framework/tests/pk_relations.py
+18
-0
No files found.
rest_framework/serializers.py
View file @
743224d0
...
@@ -447,6 +447,13 @@ class ModelSerializer(Serializer):
...
@@ -447,6 +447,13 @@ class ModelSerializer(Serializer):
setattr
(
instance
,
key
,
val
)
setattr
(
instance
,
key
,
val
)
return
instance
return
instance
# Reversed relation
for
(
obj
,
model
)
in
self
.
opts
.
model
.
_meta
.
get_all_related_m2m_objects_with_model
():
field_name
=
obj
.
field
.
related_query_name
()
if
field_name
in
attrs
:
self
.
m2m_data
[
field_name
]
=
attrs
.
pop
(
field_name
)
# Forward relation
for
field
in
self
.
opts
.
model
.
_meta
.
many_to_many
:
for
field
in
self
.
opts
.
model
.
_meta
.
many_to_many
:
if
field
.
name
in
attrs
:
if
field
.
name
in
attrs
:
self
.
m2m_data
[
field
.
name
]
=
attrs
.
pop
(
field
.
name
)
self
.
m2m_data
[
field
.
name
]
=
attrs
.
pop
(
field
.
name
)
...
...
rest_framework/tests/pk_relations.py
View file @
743224d0
...
@@ -117,6 +117,24 @@ class PrimaryKeyManyToManyTests(TestCase):
...
@@ -117,6 +117,24 @@ class PrimaryKeyManyToManyTests(TestCase):
]
]
self
.
assertEquals
(
serializer
.
data
,
expected
)
self
.
assertEquals
(
serializer
.
data
,
expected
)
def
test_reverse_many_to_many_create
(
self
):
data
=
{
'id'
:
4
,
'name'
:
u'target-4'
,
'sources'
:
[
1
,
3
]}
serializer
=
ManyToManyTargetSerializer
(
data
=
data
)
self
.
assertTrue
(
serializer
.
is_valid
())
obj
=
serializer
.
save
()
self
.
assertEquals
(
serializer
.
data
,
data
)
self
.
assertEqual
(
obj
.
name
,
u'target-4'
)
# Ensure target 4 is added, and everything else is as expected
queryset
=
ManyToManyTarget
.
objects
.
all
()
serializer
=
ManyToManyTargetSerializer
(
queryset
)
expected
=
[
{
'id'
:
1
,
'name'
:
u'target-1'
,
'sources'
:
[
1
,
2
,
3
]},
{
'id'
:
2
,
'name'
:
u'target-2'
,
'sources'
:
[
2
,
3
]},
{
'id'
:
3
,
'name'
:
u'target-3'
,
'sources'
:
[
3
]},
{
'id'
:
4
,
'name'
:
u'target-4'
,
'sources'
:
[
1
,
3
]}
]
self
.
assertEquals
(
serializer
.
data
,
expected
)
class
PrimaryKeyForeignKeyTests
(
TestCase
):
class
PrimaryKeyForeignKeyTests
(
TestCase
):
def
setUp
(
self
):
def
setUp
(
self
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment