Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
66bce38b
Commit
66bce38b
authored
Dec 03, 2014
by
Kevin Brown
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #2196 from tomchristie/tomchristie-improve-update-nested-validation
Improve checks for nested creates and updates.
parents
5f2f54b7
e1d98f77
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
rest_framework/serializers.py
+4
-4
No files found.
rest_framework/serializers.py
View file @
66bce38b
...
@@ -633,8 +633,8 @@ class ModelSerializer(Serializer):
...
@@ -633,8 +633,8 @@ class ModelSerializer(Serializer):
# If we don't do this explicitly they'd likely get a confusing
# If we don't do this explicitly they'd likely get a confusing
# error at the point of calling `Model.objects.create()`.
# error at the point of calling `Model.objects.create()`.
assert
not
any
(
assert
not
any
(
isinstance
(
field
,
BaseSerializer
)
and
not
field
.
read_only
isinstance
(
field
,
BaseSerializer
)
and
(
key
in
validated_attrs
)
for
field
in
self
.
fields
.
value
s
()
for
key
,
field
in
self
.
fields
.
item
s
()
),
(
),
(
'The `.create()` method does not suport nested writable fields '
'The `.create()` method does not suport nested writable fields '
'by default. Write an explicit `.create()` method for serializer '
'by default. Write an explicit `.create()` method for serializer '
...
@@ -681,8 +681,8 @@ class ModelSerializer(Serializer):
...
@@ -681,8 +681,8 @@ class ModelSerializer(Serializer):
def
update
(
self
,
instance
,
validated_attrs
):
def
update
(
self
,
instance
,
validated_attrs
):
assert
not
any
(
assert
not
any
(
isinstance
(
field
,
BaseSerializer
)
and
not
field
.
read_only
isinstance
(
field
,
BaseSerializer
)
and
(
key
in
validated_attrs
)
for
field
in
self
.
fields
.
value
s
()
for
key
,
field
in
self
.
fields
.
item
s
()
),
(
),
(
'The `.update()` method does not suport nested writable fields '
'The `.update()` method does not suport nested writable fields '
'by default. Write an explicit `.update()` method for serializer '
'by default. Write an explicit `.update()` method for serializer '
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment