Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
5ec223bc
Commit
5ec223bc
authored
Nov 23, 2016
by
Asif Saifuddin Auvi
Committed by
Tom Christie
Nov 23, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
converted validators and write_only_fields test to pytest style (#4697)
parent
4b59ec27
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
11 deletions
+8
-11
tests/test_validators.py
+5
-8
tests/test_write_only_fields.py
+3
-3
No files found.
tests/test_validators.py
View file @
5ec223bc
...
...
@@ -94,23 +94,20 @@ class TestUniquenessValidation(TestCase):
def
test_doesnt_pollute_model
(
self
):
instance
=
AnotherUniquenessModel
.
objects
.
create
(
code
=
'100'
)
serializer
=
AnotherUniquenessSerializer
(
instance
)
self
.
assertEqual
(
AnotherUniquenessModel
.
_meta
.
get_field
(
'code'
)
.
validators
,
[])
assert
AnotherUniquenessModel
.
_meta
.
get_field
(
'code'
)
.
validators
==
[]
# Accessing data shouldn't effect validators on the model
serializer
.
data
self
.
assertEqual
(
AnotherUniquenessModel
.
_meta
.
get_field
(
'code'
)
.
validators
,
[])
assert
AnotherUniquenessModel
.
_meta
.
get_field
(
'code'
)
.
validators
==
[]
def
test_related_model_is_unique
(
self
):
data
=
{
'username'
:
'Existing'
,
'email'
:
'new-email@example.com'
}
rs
=
RelatedModelSerializer
(
data
=
data
)
self
.
assertFalse
(
rs
.
is_valid
())
self
.
assertEqual
(
rs
.
errors
,
{
'username'
:
[
'This field must be unique.'
]})
assert
not
rs
.
is_valid
()
assert
rs
.
errors
==
{
'username'
:
[
'This field must be unique.'
]}
data
=
{
'username'
:
'new-username'
,
'email'
:
'new-email@example.com'
}
rs
=
RelatedModelSerializer
(
data
=
data
)
self
.
assertTrue
(
rs
.
is_valid
()
)
assert
rs
.
is_valid
(
)
def
test_value_error_treated_as_not_unique
(
self
):
serializer
=
UniquenessIntegerSerializer
(
data
=
{
'integer'
:
'abc'
})
...
...
tests/test_write_only_fields.py
View file @
5ec223bc
...
...
@@ -20,8 +20,8 @@ class WriteOnlyFieldTests(TestCase):
'password'
:
'123'
}
serializer
=
self
.
Serializer
(
data
=
data
)
self
.
assertTrue
(
serializer
.
is_valid
()
)
self
.
assertEqual
(
serializer
.
validated_data
,
data
)
assert
serializer
.
is_valid
(
)
assert
serializer
.
validated_data
==
data
def
write_only_fields_are_not_present_on_output
(
self
):
instance
=
{
...
...
@@ -29,4 +29,4 @@ class WriteOnlyFieldTests(TestCase):
'password'
:
'123'
}
serializer
=
self
.
Serializer
(
instance
)
self
.
assertEqual
(
serializer
.
data
,
{
'email'
:
'foo@example.com'
})
assert
serializer
.
data
==
{
'email'
:
'foo@example.com'
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment