Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
5aa204e9
Commit
5aa204e9
authored
Mar 02, 2015
by
Tom Christie
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #2619 from kwood/master
Updated CreateOnlyDefault to call set_context on its default
parents
33c4278e
b582d52a
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
0 deletions
+21
-0
rest_framework/fields.py
+2
-0
tests/test_fields.py
+19
-0
No files found.
rest_framework/fields.py
View file @
5aa204e9
...
@@ -114,6 +114,8 @@ class CreateOnlyDefault:
...
@@ -114,6 +114,8 @@ class CreateOnlyDefault:
def
set_context
(
self
,
serializer_field
):
def
set_context
(
self
,
serializer_field
):
self
.
is_update
=
serializer_field
.
parent
.
instance
is
not
None
self
.
is_update
=
serializer_field
.
parent
.
instance
is
not
None
if
callable
(
self
.
default
)
and
hasattr
(
self
.
default
,
'set_context'
):
self
.
default
.
set_context
(
serializer_field
)
def
__call__
(
self
):
def
__call__
(
self
):
if
self
.
is_update
:
if
self
.
is_update
:
...
...
tests/test_fields.py
View file @
5aa204e9
...
@@ -317,6 +317,25 @@ class TestCreateOnlyDefault:
...
@@ -317,6 +317,25 @@ class TestCreateOnlyDefault:
'text'
:
'example'
,
'text'
:
'example'
,
}
}
def
test_create_only_default_callable_sets_context
(
self
):
"""
CreateOnlyDefault instances with a callable default should set_context
on the callable if possible
"""
class
TestCallableDefault
:
def
set_context
(
self
,
serializer_field
):
self
.
field
=
serializer_field
def
__call__
(
self
):
return
"success"
if
hasattr
(
self
,
'field'
)
else
"failure"
class
TestSerializer
(
serializers
.
Serializer
):
context_set
=
serializers
.
CharField
(
default
=
serializers
.
CreateOnlyDefault
(
TestCallableDefault
()))
serializer
=
TestSerializer
(
data
=
{})
assert
serializer
.
is_valid
()
assert
serializer
.
validated_data
[
'context_set'
]
==
'success'
# Tests for field input and output values.
# Tests for field input and output values.
# ----------------------------------------
# ----------------------------------------
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment