Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
538d2e35
Commit
538d2e35
authored
May 05, 2013
by
Tom Christie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
lookup_field on hyperlink serializers
parent
2d44dc3f
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
1 deletions
+13
-1
rest_framework/relations.py
+9
-1
rest_framework/serializers.py
+4
-0
No files found.
rest_framework/relations.py
View file @
538d2e35
...
@@ -360,7 +360,15 @@ class HyperlinkedRelatedField(RelatedField):
...
@@ -360,7 +360,15 @@ class HyperlinkedRelatedField(RelatedField):
# Only try slug if it corresponds to an attribute on the object.
# Only try slug if it corresponds to an attribute on the object.
kwargs
=
{
self
.
slug_url_kwarg
:
slug
}
kwargs
=
{
self
.
slug_url_kwarg
:
slug
}
try
:
try
:
return
reverse
(
view_name
,
kwargs
=
kwargs
,
request
=
request
,
format
=
format
)
ret
=
reverse
(
view_name
,
kwargs
=
kwargs
,
request
=
request
,
format
=
format
)
if
self
.
slug_field
==
'slug'
and
self
.
slug_url_kwarg
==
'slug'
:
# If the lookup succeeds using the default slug params,
# then `slug_field` is being used implicitly, and we
# we need to warn about the pending deprecation.
msg
=
'Implicit slug field hyperlinked fields are pending deprecation.'
\
'You should set `lookup_field=slug` on the HyperlinkedRelatedField.'
warnings
.
warn
(
msg
,
PendingDeprecationWarning
,
stacklevel
=
2
)
return
ret
except
NoReverseMatch
:
except
NoReverseMatch
:
pass
pass
...
...
rest_framework/serializers.py
View file @
538d2e35
...
@@ -827,6 +827,7 @@ class HyperlinkedModelSerializerOptions(ModelSerializerOptions):
...
@@ -827,6 +827,7 @@ class HyperlinkedModelSerializerOptions(ModelSerializerOptions):
def
__init__
(
self
,
meta
):
def
__init__
(
self
,
meta
):
super
(
HyperlinkedModelSerializerOptions
,
self
)
.
__init__
(
meta
)
super
(
HyperlinkedModelSerializerOptions
,
self
)
.
__init__
(
meta
)
self
.
view_name
=
getattr
(
meta
,
'view_name'
,
None
)
self
.
view_name
=
getattr
(
meta
,
'view_name'
,
None
)
self
.
lookup_field
=
getattr
(
meta
,
'slug_field'
,
None
)
class
HyperlinkedModelSerializer
(
ModelSerializer
):
class
HyperlinkedModelSerializer
(
ModelSerializer
):
...
@@ -875,6 +876,9 @@ class HyperlinkedModelSerializer(ModelSerializer):
...
@@ -875,6 +876,9 @@ class HyperlinkedModelSerializer(ModelSerializer):
if
model_field
:
if
model_field
:
kwargs
[
'required'
]
=
not
(
model_field
.
null
or
model_field
.
blank
)
kwargs
[
'required'
]
=
not
(
model_field
.
null
or
model_field
.
blank
)
if
self
.
opts
.
lookup_field
:
kwargs
[
'lookup_field'
]
=
self
.
opts
.
lookup_field
return
self
.
_hyperlink_field_class
(
**
kwargs
)
return
self
.
_hyperlink_field_class
(
**
kwargs
)
def
get_identity
(
self
,
data
):
def
get_identity
(
self
,
data
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment