Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
486f0a93
Commit
486f0a93
authored
Mar 23, 2015
by
Ilias Kiourktsidis
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Raise error when ModelSerializer used with abstract model
parent
c9618cc0
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
35 additions
and
0 deletions
+35
-0
rest_framework/serializers.py
+4
-0
rest_framework/utils/model_meta.py
+7
-0
tests/test_model_serializer.py
+24
-0
No files found.
rest_framework/serializers.py
View file @
486f0a93
...
@@ -823,6 +823,10 @@ class ModelSerializer(Serializer):
...
@@ -823,6 +823,10 @@ class ModelSerializer(Serializer):
serializer_class
=
self
.
__class__
.
__name__
serializer_class
=
self
.
__class__
.
__name__
)
)
)
)
if
model_meta
.
is_abstract_model
(
self
.
Meta
.
model
):
raise
ValueError
(
'Cannot use ModelSerializer with Abstract Models.'
)
declared_fields
=
copy
.
deepcopy
(
self
.
_declared_fields
)
declared_fields
=
copy
.
deepcopy
(
self
.
_declared_fields
)
model
=
getattr
(
self
.
Meta
,
'model'
)
model
=
getattr
(
self
.
Meta
,
'model'
)
...
...
rest_framework/utils/model_meta.py
View file @
486f0a93
...
@@ -167,3 +167,10 @@ def _merge_relationships(forward_relations, reverse_relations):
...
@@ -167,3 +167,10 @@ def _merge_relationships(forward_relations, reverse_relations):
list
(
forward_relations
.
items
())
+
list
(
forward_relations
.
items
())
+
list
(
reverse_relations
.
items
())
list
(
reverse_relations
.
items
())
)
)
def
is_abstract_model
(
model
):
"""
Given a model class, returns a boolean True if it is abstract and False if it is not.
"""
return
hasattr
(
model
,
'Meta'
)
and
hasattr
(
model
.
_meta
,
'abstract'
)
and
model
.
_meta
.
abstract
tests/test_model_serializer.py
View file @
486f0a93
...
@@ -94,6 +94,30 @@ class TestModelSerializer(TestCase):
...
@@ -94,6 +94,30 @@ class TestModelSerializer(TestCase):
msginitial
=
'Got a `TypeError` when calling `OneFieldModel.objects.create()`.'
msginitial
=
'Got a `TypeError` when calling `OneFieldModel.objects.create()`.'
assert
str
(
excinfo
.
exception
)
.
startswith
(
msginitial
)
assert
str
(
excinfo
.
exception
)
.
startswith
(
msginitial
)
def
test_abstract_model
(
self
):
"""
Test that trying to use ModelSerializer with Abstract Models
throws a ValueError exception.
"""
class
AbstractModel
(
models
.
Model
):
afield
=
models
.
CharField
(
max_length
=
255
)
class
Meta
:
abstract
=
True
class
TestSerializer
(
serializers
.
ModelSerializer
):
class
Meta
:
model
=
AbstractModel
fields
=
(
'afield'
,)
serializer
=
TestSerializer
(
data
=
{
'afield'
:
'foo'
,
})
with
self
.
assertRaises
(
ValueError
)
as
excinfo
:
serializer
.
is_valid
()
msginitial
=
'Cannot use ModelSerializer with Abstract Models.'
assert
str
(
excinfo
.
exception
)
.
startswith
(
msginitial
)
class
TestRegularFieldMappings
(
TestCase
):
class
TestRegularFieldMappings
(
TestCase
):
def
test_regular_fields
(
self
):
def
test_regular_fields
(
self
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment