Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
3e751ccd
Commit
3e751ccd
authored
Oct 24, 2012
by
Tom Christie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix ModelSerializer logic for fields with default value, which should have required=False set
parent
0aed70dc
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
7 deletions
+6
-7
rest_framework/serializers.py
+6
-7
No files found.
rest_framework/serializers.py
View file @
3e751ccd
...
...
@@ -406,6 +406,10 @@ class ModelSerializer(Serializer):
"""
Creates a default instance of a basic non-relational field.
"""
kwargs
=
{}
if
model_field
.
has_default
():
kwargs
[
'required'
]
=
False
field_mapping
=
{
models
.
FloatField
:
FloatField
,
models
.
IntegerField
:
IntegerField
,
...
...
@@ -421,14 +425,9 @@ class ModelSerializer(Serializer):
models
.
BooleanField
:
BooleanField
,
}
try
:
ret
=
field_mapping
[
model_field
.
__class__
](
)
ret
urn
field_mapping
[
model_field
.
__class__
](
**
kwargs
)
except
KeyError
:
ret
=
ModelField
(
model_field
=
model_field
)
if
model_field
.
default
is
not
None
:
ret
.
required
=
False
return
ret
return
ModelField
(
model_field
=
model_field
,
**
kwargs
)
def
restore_object
(
self
,
attrs
,
instance
=
None
):
"""
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment