Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
39b01d68
Commit
39b01d68
authored
Dec 14, 2012
by
Tom Christie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Ensure context is passed to dynamically added fields. Fixes #476.
parent
9eaf8e43
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
7 deletions
+6
-7
rest_framework/serializers.py
+2
-5
rest_framework/tests/pagination.py
+4
-2
No files found.
rest_framework/serializers.py
View file @
39b01d68
...
@@ -171,10 +171,6 @@ class BaseSerializer(Field):
...
@@ -171,10 +171,6 @@ class BaseSerializer(Field):
for
key
in
self
.
opts
.
exclude
:
for
key
in
self
.
opts
.
exclude
:
ret
.
pop
(
key
,
None
)
ret
.
pop
(
key
,
None
)
# Initialize the fields
for
key
,
field
in
ret
.
items
():
field
.
initialize
(
parent
=
self
,
field_name
=
key
)
return
ret
return
ret
#####
#####
...
@@ -214,6 +210,7 @@ class BaseSerializer(Field):
...
@@ -214,6 +210,7 @@ class BaseSerializer(Field):
ret
.
fields
=
{}
ret
.
fields
=
{}
for
field_name
,
field
in
self
.
fields
.
items
():
for
field_name
,
field
in
self
.
fields
.
items
():
field
.
initialize
(
parent
=
self
,
field_name
=
field_name
)
key
=
self
.
get_field_key
(
field_name
)
key
=
self
.
get_field_key
(
field_name
)
value
=
field
.
field_to_native
(
obj
,
field_name
)
value
=
field
.
field_to_native
(
obj
,
field_name
)
ret
[
key
]
=
value
ret
[
key
]
=
value
...
@@ -227,6 +224,7 @@ class BaseSerializer(Field):
...
@@ -227,6 +224,7 @@ class BaseSerializer(Field):
"""
"""
reverted_data
=
{}
reverted_data
=
{}
for
field_name
,
field
in
self
.
fields
.
items
():
for
field_name
,
field
in
self
.
fields
.
items
():
field
.
initialize
(
parent
=
self
,
field_name
=
field_name
)
try
:
try
:
field
.
field_from_native
(
data
,
files
,
field_name
,
reverted_data
)
field
.
field_from_native
(
data
,
files
,
field_name
,
reverted_data
)
except
ValidationError
as
err
:
except
ValidationError
as
err
:
...
@@ -407,7 +405,6 @@ class ModelSerializer(Serializer):
...
@@ -407,7 +405,6 @@ class ModelSerializer(Serializer):
field
=
self
.
get_field
(
model_field
)
field
=
self
.
get_field
(
model_field
)
if
field
:
if
field
:
field
.
initialize
(
parent
=
self
,
field_name
=
model_field
.
name
)
ret
[
model_field
.
name
]
=
field
ret
[
model_field
.
name
]
=
field
for
field_name
in
self
.
opts
.
read_only_fields
:
for
field_name
in
self
.
opts
.
read_only_fields
:
...
...
rest_framework/tests/pagination.py
View file @
39b01d68
...
@@ -149,7 +149,6 @@ class IntegrationTestPaginationAndFiltering(TestCase):
...
@@ -149,7 +149,6 @@ class IntegrationTestPaginationAndFiltering(TestCase):
class
PassOnContextPaginationSerializer
(
pagination
.
PaginationSerializer
):
class
PassOnContextPaginationSerializer
(
pagination
.
PaginationSerializer
):
class
Meta
:
class
Meta
:
object_serializer_class
=
serializers
.
Serializer
object_serializer_class
=
serializers
.
Serializer
...
@@ -179,9 +178,12 @@ class UnitTestPagination(TestCase):
...
@@ -179,9 +178,12 @@ class UnitTestPagination(TestCase):
self
.
assertEquals
(
serializer
.
data
[
'results'
],
self
.
objects
[
20
:])
self
.
assertEquals
(
serializer
.
data
[
'results'
],
self
.
objects
[
20
:])
def
test_context_available_in_result
(
self
):
def
test_context_available_in_result
(
self
):
"""
Ensure context gets passed through to the object serializer.
"""
serializer
=
PassOnContextPaginationSerializer
(
self
.
first_page
)
serializer
=
PassOnContextPaginationSerializer
(
self
.
first_page
)
serializer
.
data
results
=
serializer
.
fields
[
serializer
.
results_field
]
results
=
serializer
.
fields
[
serializer
.
results_field
]
# assertIs is available in Python 2.7
self
.
assertTrue
(
serializer
.
context
is
results
.
context
)
self
.
assertTrue
(
serializer
.
context
is
results
.
context
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment