Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
2948305b
Commit
2948305b
authored
Jan 30, 2013
by
Tom Christie
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #632 from fernandogrd/master
Fix processing of ManyToManyField when it is empty
parents
1929159d
41364b3b
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
1 deletions
+15
-1
rest_framework/relations.py
+1
-1
rest_framework/tests/relations.py
+14
-0
No files found.
rest_framework/relations.py
View file @
2948305b
...
...
@@ -148,7 +148,7 @@ class ManyRelatedMixin(object):
value
=
data
.
getlist
(
self
.
source
or
field_name
)
except
:
# Non-form data
value
=
data
.
get
(
self
.
source
or
field_name
)
value
=
data
.
get
(
self
.
source
or
field_name
,
[]
)
else
:
if
value
==
[
''
]:
value
=
[]
...
...
rest_framework/tests/relations.py
View file @
2948305b
...
...
@@ -31,3 +31,17 @@ class FieldTests(TestCase):
field
=
serializers
.
SlugRelatedField
(
queryset
=
NullModel
.
objects
.
all
(),
slug_field
=
'pk'
)
self
.
assertRaises
(
serializers
.
ValidationError
,
field
.
from_native
,
''
)
self
.
assertRaises
(
serializers
.
ValidationError
,
field
.
from_native
,
[])
class
TestManyRelateMixin
(
TestCase
):
def
test_missing_many_to_many_related_field
(
self
):
'''
Regression test for #632
https://github.com/tomchristie/django-rest-framework/pull/632
'''
field
=
serializers
.
ManyRelatedField
(
read_only
=
False
)
into
=
{}
field
.
field_from_native
({},
None
,
'field_name'
,
into
)
self
.
assertEqual
(
into
[
'field_name'
],
[])
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment