Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
101fd290
Commit
101fd290
authored
Aug 15, 2016
by
Tom Christie
Committed by
GitHub
Aug 15, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Do not include uploads in request.POST (#4407)
parent
785b206b
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
1 deletions
+12
-1
rest_framework/request.py
+1
-1
tests/test_request.py
+11
-0
No files found.
rest_framework/request.py
View file @
101fd290
...
@@ -373,7 +373,7 @@ class Request(object):
...
@@ -373,7 +373,7 @@ class Request(object):
if
not
_hasattr
(
self
,
'_data'
):
if
not
_hasattr
(
self
,
'_data'
):
self
.
_load_data_and_files
()
self
.
_load_data_and_files
()
if
is_form_media_type
(
self
.
content_type
):
if
is_form_media_type
(
self
.
content_type
):
return
self
.
data
return
self
.
_
data
return
QueryDict
(
''
,
encoding
=
self
.
_request
.
_encoding
)
return
QueryDict
(
''
,
encoding
=
self
.
_request
.
_encoding
)
@property
@property
...
...
tests/test_request.py
View file @
101fd290
...
@@ -7,6 +7,7 @@ from django.conf.urls import url
...
@@ -7,6 +7,7 @@ from django.conf.urls import url
from
django.contrib.auth
import
authenticate
,
login
,
logout
from
django.contrib.auth
import
authenticate
,
login
,
logout
from
django.contrib.auth.models
import
User
from
django.contrib.auth.models
import
User
from
django.contrib.sessions.middleware
import
SessionMiddleware
from
django.contrib.sessions.middleware
import
SessionMiddleware
from
django.core.files.uploadedfile
import
SimpleUploadedFile
from
django.test
import
TestCase
,
override_settings
from
django.test
import
TestCase
,
override_settings
from
django.utils
import
six
from
django.utils
import
six
...
@@ -78,6 +79,16 @@ class TestContentParsing(TestCase):
...
@@ -78,6 +79,16 @@ class TestContentParsing(TestCase):
request
.
parsers
=
(
FormParser
(),
MultiPartParser
())
request
.
parsers
=
(
FormParser
(),
MultiPartParser
())
self
.
assertEqual
(
list
(
request
.
POST
.
items
()),
list
(
data
.
items
()))
self
.
assertEqual
(
list
(
request
.
POST
.
items
()),
list
(
data
.
items
()))
def
test_request_POST_with_files
(
self
):
"""
Ensure request.POST returns no content for POST request with file content.
"""
upload
=
SimpleUploadedFile
(
"file.txt"
,
b
"file_content"
)
request
=
Request
(
factory
.
post
(
'/'
,
{
'upload'
:
upload
}))
request
.
parsers
=
(
FormParser
(),
MultiPartParser
())
self
.
assertEqual
(
list
(
request
.
POST
.
keys
()),
[])
self
.
assertEqual
(
list
(
request
.
FILES
.
keys
()),
[
'upload'
])
def
test_standard_behaviour_determines_form_content_PUT
(
self
):
def
test_standard_behaviour_determines_form_content_PUT
(
self
):
"""
"""
Ensure request.data returns content for PUT request with form content.
Ensure request.data returns content for PUT request with form content.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment