Commit 0c2b534d by Tom Christie

Minor cleanup

parent 06b28f66
...@@ -129,11 +129,6 @@ class PositiveIntegerAsChoiceSerializer(serializers.ModelSerializer): ...@@ -129,11 +129,6 @@ class PositiveIntegerAsChoiceSerializer(serializers.ModelSerializer):
fields = ['some_integer'] fields = ['some_integer']
class BrokenModelSerializer(serializers.ModelSerializer):
class Meta:
fields = ['some_field']
class BasicTests(TestCase): class BasicTests(TestCase):
def setUp(self): def setUp(self):
self.comment = Comment( self.comment = Comment(
...@@ -424,8 +419,12 @@ class ValidationTests(TestCase): ...@@ -424,8 +419,12 @@ class ValidationTests(TestCase):
Assert that a meaningful exception message is outputted when the model Assert that a meaningful exception message is outputted when the model
field is missing (e.g. when mistyping ``model``). field is missing (e.g. when mistyping ``model``).
""" """
class BrokenModelSerializer(serializers.ModelSerializer):
class Meta:
fields = ['some_field']
try: try:
serializer = BrokenModelSerializer() BrokenModelSerializer()
except AssertionError as e: except AssertionError as e:
self.assertEqual(e.args[0], "Serializer class 'BrokenModelSerializer' is missing 'model' Meta option") self.assertEqual(e.args[0], "Serializer class 'BrokenModelSerializer' is missing 'model' Meta option")
except: except:
...@@ -447,7 +446,7 @@ class CustomValidationTests(TestCase): ...@@ -447,7 +446,7 @@ class CustomValidationTests(TestCase):
class CommentSerializerWithFieldValidator(CommentSerializer): class CommentSerializerWithFieldValidator(CommentSerializer):
def validate_email(self, attrs, source): def validate_email(self, attrs, source):
value = attrs[source] attrs[source]
return attrs return attrs
def validate_content(self, attrs, source): def validate_content(self, attrs, source):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment