Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
C
cs_comments_service
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
cs_comments_service
Commits
c0d9cb1e
Commit
c0d9cb1e
authored
Jul 30, 2012
by
Rocky Duan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
use argument error
parent
43e3c350
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
10 deletions
+6
-10
lib/exceptions.rb
+0
-3
lib/helpers.rb
+5
-6
models/user.rb
+1
-1
No files found.
lib/exceptions.rb
deleted
100644 → 0
View file @
43e3c350
class
ValueError
<
Exception
end
lib/helpers.rb
View file @
c0d9cb1e
...
@@ -24,22 +24,21 @@ helpers do
...
@@ -24,22 +24,21 @@ helpers do
when
"other"
when
"other"
Commentable
.
find
(
params
[
"source_id"
])
Commentable
.
find
(
params
[
"source_id"
])
else
else
raise
Value
Error
,
"Source type must be 'user', 'thread' or 'other'"
raise
Argument
Error
,
"Source type must be 'user', 'thread' or 'other'"
end
end
end
end
def
vote_for
(
obj
)
def
vote_for
(
obj
)
raise
Value
Error
,
"User id is required"
unless
user
raise
Argument
Error
,
"User id is required"
unless
user
raise
Value
Error
,
"Value is required"
unless
params
[
"value"
]
raise
Argument
Error
,
"Value is required"
unless
params
[
"value"
]
raise
Value
Error
,
"Value is invalid"
unless
%w[up down]
.
include?
params
[
"value"
]
raise
Argument
Error
,
"Value is invalid"
unless
%w[up down]
.
include?
params
[
"value"
]
user
.
vote
(
obj
,
params
[
"value"
].
to_sym
)
user
.
vote
(
obj
,
params
[
"value"
].
to_sym
)
obj
.
reload
.
to_hash
.
to_json
obj
.
reload
.
to_hash
.
to_json
end
end
def
undo_vote_for
(
obj
)
def
undo_vote_for
(
obj
)
raise
Value
Error
,
"must provide user id"
unless
user
raise
Argument
Error
,
"must provide user id"
unless
user
user
.
unvote
(
obj
)
user
.
unvote
(
obj
)
obj
.
reload
.
to_hash
.
to_json
obj
.
reload
.
to_hash
.
to_json
end
end
end
end
models/user.rb
View file @
c0d9cb1e
...
@@ -59,7 +59,7 @@ class User
...
@@ -59,7 +59,7 @@ class User
def
subscribe
(
source
)
def
subscribe
(
source
)
if
source
.
_id
==
self
.
_id
and
source
.
class
==
self
.
class
if
source
.
_id
==
self
.
_id
and
source
.
class
==
self
.
class
raise
Value
Error
,
"Cannot follow oneself"
raise
Argument
Error
,
"Cannot follow oneself"
else
else
Subscription
.
find_or_create_by
(
subscriber_id:
self
.
_id
.
to_s
,
source_id:
source
.
_id
.
to_s
,
source_type:
source
.
class
.
to_s
)
Subscription
.
find_or_create_by
(
subscriber_id:
self
.
_id
.
to_s
,
source_id:
source
.
_id
.
to_s
,
source_type:
source
.
class
.
to_s
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment