Commit 4efc1c81 by Arjun Singh

Modify abuse specs to work with identity map.

parent 6074efe7
...@@ -12,4 +12,4 @@ end ...@@ -12,4 +12,4 @@ end
put "#{APIPREFIX}/comments/:comment_id/abuse_unflag" do |comment_id| put "#{APIPREFIX}/comments/:comment_id/abuse_unflag" do |comment_id|
un_flag_as_abuse comment un_flag_as_abuse comment
end end
\ No newline at end of file
...@@ -38,11 +38,14 @@ describe "app" do ...@@ -38,11 +38,14 @@ describe "app" do
describe "flag a comment as abusive" do describe "flag a comment as abusive" do
it "create or update the abuse_flags on the comment" do it "create or update the abuse_flags on the comment" do
comment = Comment.first comment = Comment.first
prev_abuse_flaggers = comment.abuse_flaggers
# We get the count rather than just keeping the array, because the array
# will update as the Comment updates since the IdentityMap is enabled.
prev_abuse_flaggers_count = comment.abuse_flaggers.length
create_comment_flag("#{comment.id}", User.first.id) create_comment_flag("#{comment.id}", User.first.id)
comment = Comment.find(comment.id) comment = Comment.find(comment.id)
comment.abuse_flaggers.length.should == prev_abuse_flaggers.length + 1 comment.abuse_flaggers.count.should == prev_abuse_flaggers_count + 1
# verify that the thread doesn't automatically get flagged # verify that the thread doesn't automatically get flagged
comment.comment_thread.abuse_flaggers.length.should == 0 comment.comment_thread.abuse_flaggers.length.should == 0
end end
...@@ -64,11 +67,11 @@ describe "app" do ...@@ -64,11 +67,11 @@ describe "app" do
it "create or update the abuse_flags on the comment" do it "create or update the abuse_flags on the comment" do
comment = Comment.first comment = Comment.first
thread = comment.comment_thread thread = comment.comment_thread
prev_abuse_flaggers = thread.abuse_flaggers prev_abuse_flaggers_count = thread.abuse_flaggers.count
create_thread_flag("#{thread.id}", User.first.id) create_thread_flag("#{thread.id}", User.first.id)
comment = Comment.find(comment.id) comment = Comment.find(comment.id)
comment.comment_thread.abuse_flaggers.length.should == prev_abuse_flaggers.length + 1 comment.comment_thread.abuse_flaggers.count.should == prev_abuse_flaggers_count + 1
# verify that the comment doesn't automatically get flagged # verify that the comment doesn't automatically get flagged
comment.abuse_flaggers.length.should == 0 comment.abuse_flaggers.length.should == 0
end end
...@@ -92,14 +95,15 @@ describe "app" do ...@@ -92,14 +95,15 @@ describe "app" do
create_comment_flag("#{comment.id}", User.first.id) create_comment_flag("#{comment.id}", User.first.id)
comment = Comment.first comment = Comment.first
prev_abuse_flaggers = comment.abuse_flaggers prev_abuse_flaggers = comment.abuse_flaggers
prev_abuse_flaggers_count = prev_abuse_flaggers.count
prev_abuse_flaggers.should include User.first.id prev_abuse_flaggers.should include User.first.id
remove_comment_flag("#{comment.id}", User.first.id) remove_comment_flag("#{comment.id}", User.first.id)
comment = Comment.find(comment.id) comment = Comment.find(comment.id)
comment.abuse_flaggers.length.should == prev_abuse_flaggers.length - 1 comment.abuse_flaggers.count.should == prev_abuse_flaggers_count - 1
comment.abuse_flaggers.to_a.should_not include User.first.id comment.abuse_flaggers.to_a.should_not include User.first.id
end end
it "returns 400 when the thread does not exist" do it "returns 400 when the thread does not exist" do
...@@ -123,13 +127,14 @@ describe "app" do ...@@ -123,13 +127,14 @@ describe "app" do
thread = CommentThread.first thread = CommentThread.first
prev_abuse_flaggers = thread.abuse_flaggers prev_abuse_flaggers = thread.abuse_flaggers
prev_abuse_flaggers_count = prev_abuse_flaggers.count
prev_abuse_flaggers.should include User.first.id prev_abuse_flaggers.should include User.first.id
remove_thread_flag("#{thread.id}", User.first.id) remove_thread_flag("#{thread.id}", User.first.id)
thread = CommentThread.find(thread.id) thread = CommentThread.find(thread.id)
thread.abuse_flaggers.length.should == prev_abuse_flaggers.length - 1 thread.abuse_flaggers.count.should == prev_abuse_flaggers_count - 1
thread.abuse_flaggers.to_a.should_not include User.first.id thread.abuse_flaggers.to_a.should_not include User.first.id
end end
it "returns 400 when the thread does not exist" do it "returns 400 when the thread does not exist" do
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment