Fix Instructor images that can be changed.

course_discovery/apps/api/tests/test_serializers.py

@@ -1138,7 +1138,7 @@ class PersonSerializerTests(TestCase):
             'family_name': self.person.family_name,
             'bio': self.person.bio,
             'profile_image': image_field.to_representation(self.person.profile_image),
-            'profile_image_url': self.person.profile_image_url,
+            'profile_image_url': self.person.profile_image.url,
             'position': PositionSerializer(position).data,
             'works': [work.value for work in self.person.person_works.all()],
             'urls': {

course_discovery/apps/course_metadata/models.py

@@ -298,12 +298,10 @@ class Person(TimeStampedModel):
 
     @property
     def get_profile_image_url(self):
-        url = self.profile_image_url
-        if not url:
-            if self.profile_image and hasattr(self.profile_image, 'url'):
-                url = self.profile_image.url
-
-        return url
+        if self.profile_image and hasattr(self.profile_image, 'url'):
+            return self.profile_image.url
+        else:
+            return self.profile_image_url
 
 
 class Position(TimeStampedModel):

course_discovery/apps/course_metadata/tests/test_models.py

@@ -434,12 +434,16 @@ class PersonTests(TestCase):
         Verify that property returns profile_image_url if profile_image_url
         exists other wise it returns uploaded image url.
         """
-        self.assertEqual(self.person.get_profile_image_url, self.person.profile_image_url)
+        self.assertEqual(self.person.get_profile_image_url, self.person.profile_image.url)
 
         # create another person with out profile_image_url
         person = factories.PersonFactory(profile_image_url=None)
         self.assertEqual(person.get_profile_image_url, person.profile_image.url)
 
+        # create another person with out profile_image
+        person = factories.PersonFactory(profile_image=None)
+        self.assertEqual(person.get_profile_image_url, person.profile_image_url)
+
         # create another person with out profile_image_url and profile_image
         person = factories.PersonFactory(profile_image_url=None, profile_image=None)
         self.assertFalse(person.get_profile_image_url)