Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
C
course-discovery
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
course-discovery
Commits
63962ded
Commit
63962ded
authored
Feb 19, 2018
by
attiyaishaque
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix that don't allow Publisher to add negative prices for course run certificates.
parent
00e29be8
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
2 deletions
+13
-2
course_discovery/apps/publisher/forms.py
+2
-2
course_discovery/apps/publisher/tests/test_forms.py
+11
-0
No files found.
course_discovery/apps/publisher/forms.py
View file @
63962ded
...
@@ -384,7 +384,7 @@ class SeatForm(BaseForm):
...
@@ -384,7 +384,7 @@ class SeatForm(BaseForm):
]
]
type
=
forms
.
ChoiceField
(
choices
=
TYPE_CHOICES
,
required
=
False
,
label
=
_
(
'Enrollment Track'
))
type
=
forms
.
ChoiceField
(
choices
=
TYPE_CHOICES
,
required
=
False
,
label
=
_
(
'Enrollment Track'
))
price
=
forms
.
DecimalField
(
max_digits
=
6
,
decimal_places
=
2
,
required
=
False
,
initial
=
0.00
)
price
=
forms
.
DecimalField
(
max_digits
=
6
,
min_value
=
0.01
,
decimal_places
=
2
,
required
=
False
,
initial
=
0.00
)
credit_price
=
forms
.
DecimalField
(
max_digits
=
6
,
decimal_places
=
2
,
required
=
False
,
initial
=
0.00
)
credit_price
=
forms
.
DecimalField
(
max_digits
=
6
,
decimal_places
=
2
,
required
=
False
,
initial
=
0.00
)
class
Meta
:
class
Meta
:
...
@@ -458,7 +458,7 @@ class CourseEntitlementForm(BaseForm):
...
@@ -458,7 +458,7 @@ class CourseEntitlementForm(BaseForm):
mode
=
forms
.
ChoiceField
(
choices
=
MODE_CHOICES
,
required
=
False
,
label
=
_
(
'Enrollment Track'
),
mode
=
forms
.
ChoiceField
(
choices
=
MODE_CHOICES
,
required
=
False
,
label
=
_
(
'Enrollment Track'
),
initial
=
CourseEntitlement
.
VERIFIED
)
initial
=
CourseEntitlement
.
VERIFIED
)
price
=
forms
.
DecimalField
(
max_digits
=
6
,
decimal_places
=
2
,
required
=
False
,
initial
=
0.00
)
price
=
forms
.
DecimalField
(
max_digits
=
6
,
min_value
=
0.01
,
decimal_places
=
2
,
required
=
False
,
initial
=
0.00
)
class
Meta
:
class
Meta
:
fields
=
(
'mode'
,
'price'
)
fields
=
(
'mode'
,
'price'
)
...
...
course_discovery/apps/publisher/tests/test_forms.py
View file @
63962ded
...
@@ -391,6 +391,17 @@ class PublisherCourseEntitlementFormTests(TestCase):
...
@@ -391,6 +391,17 @@ class PublisherCourseEntitlementFormTests(TestCase):
self
.
assertEqual
(
entitlement_form
.
clean
(),
entitlement_form
.
cleaned_data
)
self
.
assertEqual
(
entitlement_form
.
clean
(),
entitlement_form
.
cleaned_data
)
def
test_negative_price
(
self
):
"""
Verify that form raises an error when price is in -ive
"""
form_data
=
{
'mode'
:
CourseEntitlement
.
VERIFIED
,
'price'
:
-
0.05
}
entitlement_form
=
CourseEntitlementForm
(
data
=
form_data
)
self
.
assertFalse
(
entitlement_form
.
is_valid
())
self
.
assertEqual
(
entitlement_form
.
errors
,
{
'price'
:
[
'Ensure this value is greater than or equal to 0.01.'
,
''
]}
)
@pytest.mark.django_db
@pytest.mark.django_db
class
TestSeatForm
:
class
TestSeatForm
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment