Skip to content

C
course-discovery
Commit 54b69c55 by Clinton Blackburn Committed by Clinton Blackburn
Options

Updated Publisher page titles and breadcrumbs to include course numbers 

Internally, the number has more value than the course title.
parent 6ede0f41
Showing with 26 additions and 29 deletions
course_discovery/apps/publisher/templates/publisher/course_detail.html
......@@ -2,7 +2,7 @@
{% load i18n %}
{% load static %}
{% block title %}
{% trans "Course Detail" %}
{{ object.number }}
{% endblock title %}
{% block page_content %}
......
course_discovery/apps/publisher/templates/publisher/course_run_detail/course_run_detail.html
......@@ -5,7 +5,7 @@
{% load static %}
{% block title %}
{% trans "Course Run Details" %}
{{ object.course.number }} - {{ object.start|date:'M Y' }}
{% endblock title %}
{% block page_content %}
......
course_discovery/apps/publisher/tests/test_views.py
......@@ -878,7 +878,13 @@ class CourseRunDetailTests(SiteMixin, TestCase):
self.assertContains(response, '<li class="breadcrumb-item ">')
self.assertContains(response, '<a href="/publisher/courses/">Courses</a>')
page_url = reverse('publisher:publisher_course_detail', kwargs={'pk': course_run.course.id})
self.assertContains(response, '<a href="{url}">{slug}</a>'.format(url=page_url, slug=course_run.course.title))
self.assertContains(
response,
'<a href="{url}">{number}: {title}</a>'.format(
url=page_url,
number=course_run.course.number,
title=course_run.course.title)
)
self.assertContains(response, '<li class="breadcrumb-item active">')
self.assertContains(
response, '{type}: {start}'.format(
......@@ -1982,7 +1988,9 @@ class CourseDetailViewTests(TestCase):
self.assertContains(response, self.course.faq)
self.assertContains(response, self.course.video_link)
self.assertContains(response, self.course.syllabus)
self.assertEqual(response.context['breadcrumbs'][1]['slug'], self.course.title)
assert response.context['breadcrumbs'][1]['slug'] == '{number}: {title}'.format(
number=self.course.number,
title=self.course.course_title)
def test_details_page_with_course_runs_lms_id(self):
""" Test that user can see course runs with lms-id on course detail page. """
......@@ -2278,7 +2286,6 @@ class CourseDetailViewTests(TestCase):
self.assertContains(response, short_description)
self.assertContains(response, full_description)
self.assertContains(response, title)
self.assertEqual(response.context['breadcrumbs'][1]['slug'], title)
def _assign_user_permission(self):
""" Assign permissions."""
......
course_discovery/apps/publisher/views.py
......@@ -186,10 +186,10 @@ class CourseRunDetailView(mixins.LoginRequiredMixin, mixins.PublisherPermissionM
start_date = course_run.start.strftime("%B %d, %Y") if course_run.start else None
context['breadcrumbs'] = make_bread_crumbs(
[
(reverse('publisher:publisher_courses'), 'Courses'),
(reverse('publisher:publisher_courses'), _('Courses')),
(
reverse('publisher:publisher_course_detail', kwargs={'pk': course_run.course.id}),
course_run.course.title
'{number}: {title}'.format(number=course_run.course.number, title=course_run.course.title)
),
(None, '{type}: {start}'.format(
type=course_run.get_pacing_type_display(), start=start_date
......@@ -451,8 +451,8 @@ class CourseDetailView(mixins.LoginRequiredMixin, mixins.PublisherPermissionMixi
context['breadcrumbs'] = make_bread_crumbs(
[
(reverse('publisher:publisher_courses'), 'Courses'),
(None, course.course_title),
(reverse('publisher:publisher_courses'), _('Courses')),
(None, '{number}: {title}'.format(number=course.number, title=course.course_title)),
]
)
context['comment_object'] = course
......
course_discovery/conf/locale/en/LC_MESSAGES/django.po
......@@ -7,14 +7,14 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-09-28 00:13-0400\n"
"POT-Creation-Date: 2017-09-28 12:02-0400\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
"Language: \n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Language: \n"
#: apps/api/filters.py
#, python-brace-format
......@@ -1431,7 +1431,6 @@ msgid ""
msgstr ""
#: apps/publisher/templates/publisher/admin/import_course.html
#: apps/publisher/templates/publisher/course_detail.html
msgid "Course Detail"
msgstr ""
......@@ -1445,7 +1444,7 @@ msgid "Dashboard"
msgstr ""
#: apps/publisher/templates/publisher/base.html
#: apps/publisher/templates/publisher/course_list.html
#: apps/publisher/templates/publisher/course_list.html apps/publisher/views.py
msgid "Courses"
msgstr ""
......@@ -2457,10 +2456,6 @@ msgid "Reason for declining preview"
msgstr ""
#: apps/publisher/templates/publisher/course_run_detail/course_run_detail.html
msgid "Course Run Details"
msgstr ""
#: apps/publisher/templates/publisher/course_run_detail/course_run_detail.html
#, python-format
msgid ""
"The About page for this course run was published on %(course_publish_date)s."
......
course_discovery/conf/locale/en/LC_MESSAGES/djangojs.po
......@@ -7,14 +7,14 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-09-28 00:13-0400\n"
"POT-Creation-Date: 2017-09-28 12:02-0400\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
"Language: \n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Language: \n"
#: static/js/catalogs-change-form.js
msgid "Preview"
......
course_discovery/conf/locale/eo/LC_MESSAGES/django.po
......@@ -7,14 +7,14 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-09-28 00:13-0400\n"
"POT-Creation-Date: 2017-09-28 12:02-0400\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
"Language: \n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Language: \n"
"Plural-Forms: nplurals=2; plural=(n != 1);\n"
#: apps/api/filters.py
......@@ -1671,7 +1671,6 @@ msgstr ""
"möré üsér öptïöns. Ⱡ'σяєм ιρѕυм ∂σłσя ѕιт αмєт, ¢ση#"
#: apps/publisher/templates/publisher/admin/import_course.html
#: apps/publisher/templates/publisher/course_detail.html
msgid "Course Detail"
msgstr "Çöürsé Détäïl Ⱡ'σяєм ιρѕυм ∂σłσя ѕι#"
......@@ -1685,7 +1684,7 @@ msgid "Dashboard"
msgstr "Däshßöärd Ⱡ'σяєм ιρѕυм ∂σł#"
#: apps/publisher/templates/publisher/base.html
#: apps/publisher/templates/publisher/course_list.html
#: apps/publisher/templates/publisher/course_list.html apps/publisher/views.py
msgid "Courses"
msgstr "Çöürsés Ⱡ'σяєм ιρѕυм #"
......@@ -2897,10 +2896,6 @@ msgid "Reason for declining preview"
msgstr "Réäsön för déçlïnïng prévïéw Ⱡ'σяєм ιρѕυм ∂σłσя ѕιт αмєт, ¢σηѕє¢#"
#: apps/publisher/templates/publisher/course_run_detail/course_run_detail.html
msgid "Course Run Details"
msgstr "Çöürsé Rün Détäïls Ⱡ'σяєм ιρѕυм ∂σłσя ѕιт αмєт#"
#: apps/publisher/templates/publisher/course_run_detail/course_run_detail.html
#, python-format
msgid ""
"The About page for this course run was published on %(course_publish_date)s."
......
course_discovery/conf/locale/eo/LC_MESSAGES/djangojs.po
......@@ -7,14 +7,14 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-09-28 00:13-0400\n"
"POT-Creation-Date: 2017-09-28 12:02-0400\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
"Language: \n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Language: \n"
"Plural-Forms: nplurals=2; plural=(n != 1);\n"
#: static/js/catalogs-change-form.js
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment