Fix instructor profile image upload error

Fix the bug introduced when the profile_image_url attribute on the API was removed
EDUCATOR-1692

course_discovery/apps/api/serializers.py

@@ -247,7 +247,8 @@ class PositionSerializer(serializers.ModelSerializer):
 class PersonSerializer(serializers.ModelSerializer):
     """Serializer for the ``Person`` model."""
     position = PositionSerializer(required=False)
-    profile_image = serializers.CharField(read_only=True, source='get_profile_image_url')
+    profile_image_url = serializers.CharField(read_only=True, source='get_profile_image_url')
+    profile_image = StdImageSerializerField(required=False)
     works = serializers.SlugRelatedField(many=True, read_only=True, slug_field='value', source='person_works')
     urls = serializers.SerializerMethodField()
     email = serializers.EmailField(required=True)
@@ -262,7 +263,7 @@ class PersonSerializer(serializers.ModelSerializer):
         model = Person
         fields = (
             'uuid', 'given_name', 'family_name', 'bio', 'slug', 'position', 'profile_image',
-            'partner', 'works', 'urls', 'email'
+            'partner', 'works', 'urls', 'email', 'profile_image_url',
         )
         extra_kwargs = {
             'partner': {'write_only': True}

course_discovery/apps/api/tests/test_serializers.py

@@ -1111,6 +1111,8 @@ class PersonSerializerTests(TestCase):
     def setUp(self):
         request = make_request()
         self.context = {'request': request}
+        image_field = StdImageSerializerField()
+        image_field._context = self.context  # pylint: disable=protected-access
 
         position = PositionFactory()
         self.person = position.person
@@ -1119,7 +1121,8 @@ class PersonSerializerTests(TestCase):
             'given_name': self.person.given_name,
             'family_name': self.person.family_name,
             'bio': self.person.bio,
-            'profile_image': self.person.profile_image_url,
+            'profile_image': image_field.to_representation(self.person.profile_image),
+            'profile_image_url': self.person.profile_image_url,
             'position': PositionSerializer(position).data,
             'works': [work.value for work in self.person.person_works.all()],
             'urls': {
@@ -1137,7 +1140,7 @@ class PersonSerializerTests(TestCase):
 
     def test_profile_image_url_override(self):
         self.person.profile_image_url = None
-        self.expected['profile_image'] = self.person.profile_image.url
+        self.expected['profile_image_url'] = self.person.profile_image.url
         serializer = PersonSerializer(self.person, context=self.context)
         self.assertDictEqual(serializer.data, self.expected)
 

course_discovery/static/js/publisher/instructors.js

@@ -247,7 +247,7 @@ $(document).on('click', '.selected-instructor a.edit', function (e) {
     $.getJSON({
         url: btnInstructor.data('url') + uuid,
         success: function (data) {
-            $('.select-image').attr('src', data['profile_image']);
+            $('.select-image').attr('src', data['profile_image_url']);
             $('#given-name').val(data['given_name']);
             $('#family-name').val(data['family_name']);
             $('#title').val(data['position']['title']);