Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
C
course-discovery
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
course-discovery
Commits
41b51d08
Commit
41b51d08
authored
May 18, 2018
by
asadazam93
Committed by
AsadAzam
May 18, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed filtering by course number on dashboard
parent
e567927e
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
1 deletions
+21
-1
course_discovery/apps/publisher/tests/test_views.py
+20
-0
course_discovery/apps/publisher/views.py
+1
-1
No files found.
course_discovery/apps/publisher/tests/test_views.py
View file @
41b51d08
...
...
@@ -2211,6 +2211,26 @@ class CourseListViewPaginationTests(PaginationMixin, TestCase):
reverse
=
self
.
sort_directions
[
direction
]),
internal_users_statuses
)
@ddt.data
(
{
'direction'
:
'asc'
},
{
'direction'
:
'desc'
},
)
@ddt.unpack
def
test_ordering_with_course_number_column
(
self
,
direction
):
"""
Verify that ordering by course number column is working as expected.
"""
for
page
in
(
1
,
2
,
3
):
courses
=
self
.
get_courses
(
query_params
=
{
'sortColumn'
:
1
,
'sortDirection'
:
direction
,
'pageSize'
:
4
,
'page'
:
page
}
)
course_numbers
=
[
course
[
'number'
]
for
course
in
courses
]
self
.
assertEqual
(
sorted
(
course_numbers
,
key
=
lambda
number
:
number
.
lower
(),
reverse
=
self
.
sort_directions
[
direction
]),
course_numbers
)
class
CourseDetailViewTests
(
TestCase
):
""" Tests for the course detail view. """
...
...
course_discovery/apps/publisher/views.py
View file @
41b51d08
...
...
@@ -1138,7 +1138,7 @@ class CourseListView(mixins.LoginRequiredMixin, ListView):
# record can be returned multiple times. We are not doing ordering for these fields
ordering_fields
=
{
0
:
'title'
,
# 1: 'organizations__key
',
1
:
'number
'
,
# 2: 'course_user_roles__user__full_name',
3
:
'course_runs_count'
,
4
:
'course_state__owner_role_modified'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment