Commit 4035a756 by McKenzie Welter Committed by McKenzie Welter

update form validation for max_effort default over min_effort

test fix
parent 499f9985
......@@ -336,8 +336,8 @@ class CourseRunForm(BaseForm):
raise ValidationError({'min_effort': _('Minimum effort cannot be greater than Maximum effort')})
if min_effort and max_effort and min_effort == max_effort:
raise ValidationError({'min_effort': _('Minimum effort and Maximum effort can not be same')})
if not min_effort and max_effort:
raise ValidationError({'min_effort': _('Minimum effort can not be empty')})
if not max_effort and min_effort:
raise ValidationError({'max_effort': _('Maximum effort can not be empty')})
if is_xseries and not xseries_name:
raise ValidationError({'xseries_name': _('Enter XSeries program name')})
if is_micromasters and not micromasters_name:
......
......@@ -98,16 +98,16 @@ class PublisherCourseRunEditFormTests(TestCase):
def test_minimum__effort_is_not_empty(self):
"""
Verify that 'clean' raises 'ValidationError' error if Minimum effort is
Verify that 'clean' raises 'ValidationError' error if Maximum effort is
empty.
"""
run_form = CourseRunForm()
run_form.cleaned_data = {'max_effort': 4}
run_form.cleaned_data = {'min_effort': 4}
with self.assertRaises(ValidationError) as err:
run_form.clean()
self.assertEqual(str(err.exception), "{'min_effort': ['Minimum effort can not be empty']}")
run_form.cleaned_data['min_effort'] = 1
self.assertEqual(str(err.exception), "{'max_effort': ['Maximum effort can not be empty']}")
run_form.cleaned_data['max_effort'] = 5
self.assertEqual(run_form.clean(), run_form.cleaned_data)
def test_course_run_dates(self):
......
......@@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-11-08 16:04+0000\n"
"POT-Creation-Date: 2017-11-15 14:00+0000\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
......@@ -777,7 +777,7 @@ msgid "Minimum effort and Maximum effort can not be same"
msgstr ""
#: apps/publisher/forms.py
msgid "Minimum effort can not be empty"
msgid "Maximum effort can not be empty"
msgstr ""
#: apps/publisher/forms.py
......
......@@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-11-08 16:04+0000\n"
"POT-Creation-Date: 2017-11-15 14:00+0000\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
......
......@@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-11-08 16:04+0000\n"
"POT-Creation-Date: 2017-11-15 14:00+0000\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
......@@ -930,8 +930,8 @@ msgstr ""
"αмєт, ¢σηѕє¢тєтυя α#"
#: apps/publisher/forms.py
msgid "Minimum effort can not be empty"
msgstr "Mïnïmüm éffört çän nöt ßé émptý Ⱡ'σяєм ιρѕυм ∂σłσя ѕιт αмєт, ¢σηѕє¢т#"
msgid "Maximum effort can not be empty"
msgstr "Mäxïmüm éffört çän nöt ßé émptý Ⱡ'σяєм ιρѕυм ∂σłσя ѕιт αмєт, ¢σηѕє¢т#"
#: apps/publisher/forms.py
msgid "Enter XSeries program name"
......
......@@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-11-08 16:04+0000\n"
"POT-Creation-Date: 2017-11-15 14:00+0000\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment