Commit 3a495a7d by Tasawer Nawaz Committed by GitHub

Merge pull request #462 from edx/tasawer/ecom-6394-banner-img-issue

Override custom method to replace img variations
parents 48b3face 89c429d5
......@@ -24,7 +24,7 @@ from course_discovery.apps.course_metadata.choices import CourseRunStatus, Cours
from course_discovery.apps.course_metadata.publishers import MarketingSitePublisher
from course_discovery.apps.course_metadata.query import CourseQuerySet, CourseRunQuerySet, ProgramQuerySet
from course_discovery.apps.course_metadata.utils import UploadToFieldNamePath
from course_discovery.apps.course_metadata.utils import clean_query
from course_discovery.apps.course_metadata.utils import clean_query, custom_render_variations
from course_discovery.apps.ietf_language_tags.models import LanguageTag
logger = logging.getLogger(__name__)
......@@ -625,7 +625,8 @@ class Program(TimeStampedModel):
'medium': (726, 242),
'small': (435, 145),
'x-small': (348, 116),
}
},
render_variations=custom_render_variations
)
banner_image_url = models.URLField(null=True, blank=True, help_text='DEPRECATED: Use the banner image field.')
card_image_url = models.URLField(null=True, blank=True, help_text=_('Image used for discovery cards'))
......
from stdimage.models import StdImageFieldFile
from stdimage.utils import UploadTo
RESERVED_ELASTICSEARCH_QUERY_OPERATORS = ('AND', 'OR', 'NOT', 'TO',)
......@@ -42,3 +43,23 @@ class UploadToFieldNamePath(UploadTo):
'name': field_value
})
return super(UploadToFieldNamePath, self).__call__(instance, filename)
def custom_render_variations(file_name, variations, storage, replace=True):
""" Utility method used to override default behaviour of StdImageFieldFile by
passing it replace=True.
Args:
file_name (str): name of the image file.
variations (dict): dict containing variations of image
storage (Storage): Storage class responsible for storing the image.
Returns:
False (bool): to prevent its default behaviour
"""
for variation in variations.values():
StdImageFieldFile.render_variation(file_name, variation, replace, storage)
# to prevent default behaviour
return False
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment