Commit 0ed68ccd by Adeel Khan Committed by adeel khan

Fix enables person family name in discovery to be empty.

Adding person in discovery throws 500 if family name is
empty. Person expects family name to generate full name.
This fix would enable family name to be empty as its not a
required field.

LEARNER-1701
parent 05fde681
......@@ -222,7 +222,10 @@ class Person(TimeStampedModel):
@property
def full_name(self):
return ' '.join((self.given_name, self.family_name,))
if self.family_name:
return ' '.join((self.given_name, self.family_name,))
else:
return self.given_name
@property
def get_profile_image_url(self):
......
......@@ -358,6 +358,12 @@ class PersonTests(TestCase):
expected = self.person.given_name + ' ' + self.person.family_name
self.assertEqual(self.person.full_name, expected)
def test_empty_family_name(self):
""" Verify the property returns the person's given name when family name is set None. """
self.person.family_name = None
expected = self.person.given_name
self.assertEqual(self.person.full_name, expected)
def test_get_profile_image_url(self):
"""
Verify that property returns profile_image_url if profile_image_url
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment