Commit ed893482 by Calen Pennington Committed by Jesse Zoldak

fixup! Only sort stats in the Formatter that needs them sorted

parent 5a8f9694
...@@ -102,7 +102,7 @@ class DatadogTimingLogger(TimingLogger): ...@@ -102,7 +102,7 @@ class DatadogTimingLogger(TimingLogger):
return return
datadog_tasks_metrics = [] datadog_tasks_metrics = []
for name, timestamp in results: for name, timestamp in results.items():
datadog_tasks_metrics.append({ datadog_tasks_metrics.append({
'metric': 'edx.ansible.task_duration', 'metric': 'edx.ansible.task_duration',
'date_happened': time.mktime(timestamp.start.timetuple()), 'date_happened': time.mktime(timestamp.start.timetuple()),
...@@ -143,7 +143,7 @@ class JsonTimingLogger(TimingLogger): ...@@ -143,7 +143,7 @@ class JsonTimingLogger(TimingLogger):
return return
messages = [] messages = []
for name, timestamp in results: for name, timestamp in results.items():
messages.append({ messages.append({
'task': name, 'task': name,
'playbook': playbook_name, 'playbook': playbook_name,
...@@ -196,13 +196,13 @@ class LoggingTimingLogger(TimingLogger): ...@@ -196,13 +196,13 @@ class LoggingTimingLogger(TimingLogger):
print('JZJZJZ in log_play for LoggingTimingLogger') print('JZJZJZ in log_play for LoggingTimingLogger')
# Sort the tasks by their running time # Sort the tasks by their running time
results = sorted( sorted_results = sorted(
results.items(), results.items(),
key=lambda (task, timestamp): timestamp.duration, key=lambda (task, timestamp): timestamp.duration,
reverse=True reverse=True
) )
for name, timestamp in results[:10]: for name, timestamp in sorted_results[:10]:
LOGGER.info( LOGGER.info(
"{0:-<80}{1:->8}".format( "{0:-<80}{1:->8}".format(
'{0} '.format(name), '{0} '.format(name),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment