Cleanup for PR

playbooks/ec2.ini

 [ec2]
 regions=all
 destination_variable=public_dns_name
-vpc_destination_variable=private_ip_address
+vpc_destination_variable=private_dns_name
 cache_path=/tmp
 cache_max_age=300

playbooks/group_vars/all

@@ -2,13 +2,10 @@
 app_base_dir: /opt/wwc
 log_base_dir: /mnt/logs
 venv_dir: /opt/edx
-platform_code_dir: $app_base_dir/edx-platform
-os_name: ubuntu
 
 # these pathes are relative to the playbook dir
 # directory for secret settings (keys, etc)
-secure_dir: '../../edx-secret'
-
+secure_dir: 'secure_example'
 # this indicates the path to site-specific (with precedence)
 # things like nginx template files
 local_dir:  '../../ansible_local'

playbooks/roles/common/tasks/create_users.yml

@@ -20,7 +20,6 @@
   user: name={{ item.user }} append=yes groups={{ "adm,edx,"+",".join(item.groups) }} shell=/bin/bash
   with_items: admin_users
   when: admin_users is defined
-  sudo: True
   tags:
   - users
   - admin_users

playbooks/roles/common/tasks/create_venv.yml

@@ -5,21 +5,25 @@
   tags:
   - venv_base
   - install
+
 - name: pip install virtualenv
   pip: name=virtualenv state=latest
   tags:
   - venv_base
   - install
+
 - name: pip install virtualenvwrapper
   pip: name=virtualenvwrapper state=latest
   tags:
   - venv_base
   - install
+
 - name: create edx virtualenv directory
   file: path=$venv_dir owner=ubuntu group=adm mode=2775 state=directory
   tags:
   - venv_base
   - install
+
 - name: create the edx virtualenv directory initial contents
   command: /usr/local/bin/virtualenv $venv_dir creates=$venv_dir/bin/activate
   tags:

playbooks/roles/common/tasks/edx_logging_base.yml

@@ -19,7 +19,7 @@
   - update
 
 - name: Set permissions on tracking file
-  file: path={{log_base_dir}}/tracking.log owner=syslog group=adm mode=750
+  file: path={{log_base_dir}}/tracking.log owner=syslog group=adm mode=640
   tags:
   - logging
   - update

playbooks/roles/common/tasks/software_update.yml

 ---
 - name: edx-update.sh, manual lms/cms update script
-  template: src=edx-update.sh.j2 dest=/usr/local/bin/edx-update.sh owner=ubuntu group=adm mode=0775
+  copy: src=roles/common/files/edx-update.sh dest=/usr/local/bin/edx-update.sh owner=ubuntu group=adm mode=0775
   tags:
-  - update
   - release
+  - update