Merge pull request #3832 from edx/nedbat/remove-obsolete-doc-link-settings

WIP: Remove obsolete doc link settings

CHANGELOG.md

 - Role: edxapp
-  - DOC_LINK_BASE settings will be obsoleted, replaced by HELP_TOKENS_BOOKS
+  - DOC_LINK_BASE settings have been removed, replaced by HELP_TOKENS_BOOKS
 
 - Role: edxapp
   - Add the EDXAPP_LANGUAGE_COOKIE setting

playbooks/roles/edxapp/defaults/main.yml

@@ -295,9 +295,6 @@ EDXAPP_TIME_ZONE: 'America/New_York'
 EDXAPP_HELP_TOKENS_BOOKS:
     learner: "http://edx.readthedocs.io/projects/open-edx-learner-guide"
     course_author: "http://edx.readthedocs.io/projects/open-edx-building-and-running-a-course"
-# HELP_TOKENS_BOOKS obsoletes DOC_LINK_BASE_URL. These will be removed soon.
-EDXAPP_LMS_DOC_LINK_BASE_URL: 'https://edx.readthedocs.io/projects/open-edx-learner-guide'
-EDXAPP_CMS_DOC_LINK_BASE_URL: 'https://edx.readthedocs.io/projects/open-edx-building-and-running-a-course'
 
 EDXAPP_TECH_SUPPORT_EMAIL: 'technical@example.com'
 EDXAPP_CONTACT_EMAIL: 'info@example.com'
@@ -1106,7 +1103,6 @@ lms_env_config:
   API_ACCESS_FROM_EMAIL: "{{ EDXAPP_API_ACCESS_FROM_EMAIL }}"
   API_DOCUMENTATION_URL: "{{ EDXAPP_API_DOCUMENTATION_URL }}"
   AUTH_DOCUMENTATION_URL: "{{ EDXAPP_AUTH_DOCUMENTATION_URL }}"
-  DOC_LINK_BASE_URL: "{{ EDXAPP_LMS_DOC_LINK_BASE_URL }}"
   RECALCULATE_GRADES_ROUTING_KEY: "{{ EDXAPP_RECALCULATE_GRADES_ROUTING_KEY }}"
   CELERY_QUEUES: "{{ EDXAPP_LMS_CELERY_QUEUES }}"
   ALTERNATE_WORKER_QUEUES: "cms"
@@ -1140,7 +1136,6 @@ cms_env_config:
   <<: *edxapp_generic_env
   SITE_NAME:  "{{ EDXAPP_CMS_SITE_NAME }}"
   GIT_REPO_EXPORT_DIR: "{{ EDXAPP_GIT_REPO_EXPORT_DIR }}"
-  DOC_LINK_BASE_URL: "{{ EDXAPP_CMS_DOC_LINK_BASE_URL }}"
   CELERY_QUEUES: "{{ EDXAPP_CMS_CELERY_QUEUES }}"
   ALTERNATE_WORKER_QUEUES: "lms"
   COURSE_IMPORT_EXPORT_BUCKET: "{{ EDXAPP_IMPORT_EXPORT_BUCKET }}"