More fixes to move to new syntax.

playbooks/roles/analytics_api/tasks/main.yml

@@ -75,8 +75,8 @@
     - migrate:db
 
 - name: run collectstatic
-  shell:
-  args: "{{ analytics_api_home }}/venvs/{{ analytics_api_service_name }}/bin/python manage.py collectstatic  --noinput"
+  shell: "{{ analytics_api_home }}/venvs/{{ analytics_api_service_name }}/bin/python manage.py collectstatic  --noinput"
+  args:
     chdir: "{{ analytics_api_code_dir }}"
   become_user: "{{ analytics_api_user }}"
   environment: "{{ analytics_api_environment }}"
@@ -110,7 +110,8 @@
   template:
     src: edx/app/supervisor/conf.d.available/analytics_api.conf.j2
     dest: "{{ supervisor_available_dir }}/{{ analytics_api_service_name }}.conf"
-    owner: "{{ supervisor_user }} group={{ common_web_user }}"
+    owner: "{{ supervisor_user }}"
+    group: "{{ common_web_user }}"
     mode: 0644
   tags:
     - install

playbooks/roles/browsermob-proxy/tasks/main.yml

@@ -9,7 +9,7 @@
 - name: unzip into /var/tmp/
   shell: "unzip /var/tmp/browsermob-proxy-{{ browsermob_proxy_version }}.zip"
   args:
-    chdir=/var/tmp
+    chdir: "/var/tmp"
   when: download_browsermob_proxy.changed
 
 - name: move to /etc/browsermob-proxy/

playbooks/roles/credentials/tasks/main.yml

@@ -43,8 +43,8 @@
     - install:app-requirements
 
 - name: create nodeenv
-  shell:
-  args: "{{ credentials_venv_dir }}/bin/nodeenv {{ credentials_nodeenv_dir }} --prebuilt"
+  shell: "{{ credentials_venv_dir }}/bin/nodeenv {{ credentials_nodeenv_dir }} --prebuilt"
+  args:
     creates: "{{ credentials_nodeenv_dir }}"
   become_user: "{{ credentials_user }}"
   tags:

playbooks/roles/ecommerce/tasks/main.yml

@@ -86,7 +86,7 @@
 - name: Populate countries
   shell: "DB_MIGRATION_USER={{ COMMON_MYSQL_MIGRATE_USER }} DB_MIGRATION_PASS={{ COMMON_MYSQL_MIGRATE_PASS }} {{ ecommerce_venv_dir }}/bin/python ./manage.py oscar_populate_countries"
   args:
-    chdir: {{ ecommerce_code_dir }}
+    chdir: "{{ ecommerce_code_dir }}"
   become_user: "{{ ecommerce_user }}"
   environment: "{{ ecommerce_environment }}"
   when: migrate_db is defined and migrate_db|lower == "yes"

playbooks/roles/gitreload/tasks/deploy.yml

 - name: create ssh dir for the content repos key
-  file: path=~/.ssh state=directory mode=0700
+  file:
+    path: "~/.ssh"
+    state: "directory"
+    mode: "0700"
   become_user: "{{ common_web_user }}"
 
 - name: install ssh key for the content repos
-  copy: content="{{ GITRELOAD_GIT_IDENTITY }}" dest=~/.ssh/id_rsa mode=0600
+  copy:
+    content: "{{ GITRELOAD_GIT_IDENTITY }}"
+    dest: "~/.ssh/id_rsa"
+    mode: "0600"
   become_user: "{{ common_web_user }}"
 
 - include: course_pull.yml
@@ -19,27 +25,36 @@
   notify: restart gitreload
 
 - name: copy configuration
-  template: src=edx/app/gitreload/gr.env.json.j2 dest={{ gitreload_dir }}/gr.env.json
+  template:
+    src: "edx/app/gitreload/gr.env.json.j2"
+    dest: "{{ gitreload_dir }}/gr.env.json"
   become_user: "{{ gitreload_user }}"
   notify: restart gitreload
 
 - name: "add gunicorn configuration file"
   template:
-    src: "edx/app/gitreload/gitreload_gunicorn.py.j2 dest={{ gitreload_dir }}/gitreload_gunicorn.py"
+    src: "edx/app/gitreload/gitreload_gunicorn.py.j2"
+    dest: "{{ gitreload_dir }}/gitreload_gunicorn.py"
   become_user: "{{ gitreload_user }}"
   notify: restart gitreload
 
 - name: "writing supervisor script"
   template:
-    src: "edx/app/supervisor/conf.available.d/gitreload.conf.j2 dest={{ supervisor_available_dir }}/gitreload.conf"
-    owner: "{{ supervisor_user }} group={{ common_web_user }} mode=0644"
+    src: "edx/app/supervisor/conf.available.d/gitreload.conf.j2"
+    dest: "{{ supervisor_available_dir }}/gitreload.conf"
+    owner: "{{ supervisor_user }}"
+    group: "{{ common_web_user }}"
+    mode: "0644"
 
 - name: "enable supervisor script"
   file:
     src: "{{ supervisor_available_dir }}/gitreload.conf"
     dest: "{{ supervisor_cfg_dir }}/gitreload.conf"
-    owner: "{{ supervisor_user }} group={{ common_web_user }} mode=0644"
-    state: link force=yes
+    owner: "{{ supervisor_user }}"
+    group: "{{ common_web_user }}"
+    mode: "0644"
+    state: link
+    force: "yes"
   when: not disable_edx_services
 
   # call supervisorctl update. this reloads

playbooks/roles/harprofiler/tasks/main.yml

@@ -53,7 +53,8 @@
     mode: 0755
   become_user: "{{ harprofiler_user }}"
 
-
 - name: test install
-  shell: "./{{ harprofiler_validation_script }} chdir={{ harprofiler_dir }}"
+  shell: "./{{ harprofiler_validation_script }}"
+  args:
+    chdir: "{{ harprofiler_dir }}"
   become_user: "{{ harprofiler_user }}"

playbooks/roles/hive/tasks/main.yml

@@ -21,7 +21,8 @@
 
 
 - name: check if downloaded and extracted
-  stat: path={{ HIVE_HOME }}
+  stat:
+    path: "{{ HIVE_HOME }}"
   register: extracted_dir
 
 - name: distribution downloaded
@@ -34,7 +35,7 @@
 - name: distribution extracted
   shell: "tar -xzf {{ hive_temporary_dir }}/{{ hive_dist.filename }} && chown -R {{ hadoop_common_user }}:{{ hadoop_common_group }} hive-{{ HIVE_VERSION }}-bin"
   args:
-    chdir={{ HADOOP_COMMON_USER_HOME }}
+    chdir: "{{ HADOOP_COMMON_USER_HOME }}"
   when: not extracted_dir.stat.exists
 
 - name: versioned directory symlink created
@@ -55,7 +56,7 @@
 - name: hive mysql connector distribution extracted
   shell: "tar -xzf {{ hive_temporary_dir }}/{{ hive_mysql_connector_dist.filename }}"
   args:
-    chdir={{ hive_temporary_dir }}
+    chdir: "{{ hive_temporary_dir }}"
   when: not extracted_dir.stat.exists
 
 - name: hive lib exists

playbooks/roles/jenkins_admin/tasks/main.yml

@@ -34,12 +34,19 @@
   when: JENKINS_ADMIN_S3_PROFILE.secret_key is not defined
 
 - name: add admin specific apt repositories
-  apt_repository: repo="{{ item }}" state=present update_cache=yes
+  apt_repository:
+    repo: "{{ item }}"
+    state: "present"
+    update_cache: "yes"
   with_items: jenkins_admin_debian_repos
 
 - name: create the scripts directory
-  file: path={{ jenkins_admin_scripts_dir }} state=directory
-        owner={{ jenkins_user }} group={{ jenkins_group }} mode=755
+  file:
+    path: "{{ jenkins_admin_scripts_dir }}"
+    state: "directory"
+    owner: "{{ jenkins_user }}"
+    group: "{{ jenkins_group }}"
+    mode: "755"
 
 - name: configure s3 plugin
   template:
@@ -47,7 +54,7 @@
     dest: "{{ jenkins_home }}/hudson.plugins.s3.S3BucketPublisher.xml"
     owner: "{{ jenkins_user }}"
     group: "{{ jenkins_group }}"
-    mode=0644
+    mode: "0644"
 
 - name: configure the boto profiles for jenkins
   template:
@@ -60,8 +67,12 @@
     - aws-config
 
 - name: create the .aws directory
-  file: path={{ jenkins_home }}/.aws state=directory
-        owner={{ jenkins_user }} group={{ jenkins_group }} mode=700
+  file:
+    path: "{{ jenkins_home }}/.aws"
+    state: "directory"
+    owner: "{{ jenkins_user }}"
+    group: "{{ jenkins_group }}"
+    mode: "700"
   tags:
     - aws-config
 
@@ -116,17 +127,23 @@
 
 # adding chris-lea nodejs repo
 - name: add ppas for current versions of nodejs
-  apt_repository: repo="{{ jenkins_chrislea_ppa }}"
+  apt_repository:
+    repo: "{{ jenkins_chrislea_ppa }}"
 
 - name: install system packages for edxapp virtualenvs
-  apt: pkg={{','.join(jenkins_admin_debian_pkgs)}} state=present update_cache=yes
+  apt:
+    pkg: "{{','.join(jenkins_admin_debian_pkgs)}}"
+    state: "present"
+    update_cache: yes
 
 # This is necessary so that ansible can run with
 # sudo set to True (as the jenkins user) on jenkins
 - name: grant sudo access to the jenkins user
   copy:
     content: "{{ jenkins_user }} ALL=({{ jenkins_user }}) NOPASSWD:ALL"
-    dest: "/etc/sudoers.d/99-jenkins owner=root group=root"
+    dest: "/etc/sudoers.d/99-jenkins"
+    owner: "root"
+    group: "root"
     mode: 0440
     validate: "visudo -cf %s"
 

playbooks/roles/jenkins_analytics/tasks/main.yml

@@ -170,8 +170,8 @@
     - jenkins-seed-job
 
 - name: generate seed job xml
-  shell:
-  args: "GRADLE_OPTS=\"-Dorg.gradle.daemon=true\" ./gradlew run -Pargs={{ jenkins_seed_job_script }}"
+  shell: "GRADLE_OPTS=\"-Dorg.gradle.daemon=true\" ./gradlew run -Pargs={{ jenkins_seed_job_script }}"
+  args:
     chdir: "{{ jenkins_seed_job_root }}"
   become: yes
   become_user: "{{ jenkins_user }}"

playbooks/roles/openstack/tasks/main.yml

@@ -57,7 +57,7 @@
   # Using the pip from inside the virtual environment implicitly installs everything into that virtual environment.
   command: "{{ edxapp_venv_dir }}/bin/pip install {{ COMMON_PIP_VERBOSITY }} -i {{ COMMON_PYPI_MIRROR_URL }} --exists-action w -r {{ openstack_requirements_file }}"
   args:
-    chdir={{ edxapp_code_dir }}
+    chdir: "{{ edxapp_code_dir }}"
   sudo_user: "{{ edxapp_user }}"
   environment: "{{ edxapp_environment }}"
   when: edxapp_code_dir is defined