Merge pull request #3209 from edx/arbab/minos-rewrite

proper YAML syntax for rewriting ansible tasks

playbooks/roles/minos/tasks/main.yml

@@ -35,27 +35,29 @@
 #
 
 #TODO: remove
-- name: maintain backwards-compatable config location
-  file: >
-    path={{ COMMON_CFG_DIR  }}/{{ minos_service_name }}/{{ minos_service_name }}.yml
-    state=link
-    src={{ COMMON_CFG_DIR  }}/{{ minos_service_name }}.yml
-    owner=root
-    group=root
+- name: Maintain backwards-compatable config location
+  file:
+    src: "{{ COMMON_CFG_DIR  }}/{{ minos_service_name }}.yml"
+    dest: "{{ COMMON_CFG_DIR  }}/{{ minos_service_name }}/{{ minos_service_name }}.yml"
+    state: link
+    owner: root
+    group: root
 
-- name: create minos config directory
-  file: >
-    path={{ minos_voter_cfg }}
-    state=directory
-    owner=root
-    group=root
-    mode=0755
+- name: Create minos config directory
+  file:
+    path: "{{ minos_voter_cfg }}"
+    state: directory
+    owner: root
+    group: root
+    mode: "0755"
   
-- name: create minos voters configs
-  template: >
-    dest={{ minos_voter_cfg }}/{{ item }}.yml
-    src=edx/etc/minos/conf.d/{{ item }}.yml.j2
-    mode=0755 owner=root group=root
+- name: Create minos voters configs
+  template:
+    dest: "{{ minos_voter_cfg }}/{{ item }}.yml"
+    src: "edx/etc/minos/conf.d/{{ item }}.yml.j2"
+    mode: "0755"
+    owner: root
+    group: root
   with_items:
     - "BellwetherVoter"
     - "ProccessQuiescenceVoterPython"
@@ -63,33 +65,27 @@
     - "ZippedTrackingLogVoter"
     - "RolledTrackingLogVoter"
 
-    # Optional auth for git
-- name: create ssh script for git (not authenticated)
-  template: >
-    src=tmp/git-identity.sh.j2 dest={{ minos_git_ssh }}
-    mode=750
-  when:
-    - MINOS_GIT_IDENTITY is not defined
+# Optional auth for git
+- name: Create ssh script for git
+  template:
+    src: "tmp/git-identity.sh.j2"
+    dest: "{{ minos_git_ssh }}"
+    mode: "0750"
 
-- name: create ssh script for git (authenticated)
-  template: >
-    src=tmp/git-identity.sh.j2 dest={{ minos_git_ssh }}
-    mode=750
-  when:
-    - MINOS_GIT_IDENTITY is defined
+- name: Install read-only ssh key
+  copy:
+    content: "{{ MINOS_GIT_IDENTITY }}"
+    dest: "{{ minos_git_identity }}"
+    force: yes
+    mode: "0600"
 
-- name: install read-only ssh key
-  copy: >
-    content="{{ MINOS_GIT_IDENTITY }}" dest="{{ minos_git_identity }}"
-    force=yes mode=0600
-
-- name: install python custom-requirements
-  pip: >
-    name="{{ item }}"
-    virtualenv="{{ minos_app_dir }}/venvs/"
-    state=present
-    extra_args="--exists-action w"
-    version="{{ minos_edx_server_tools_version }}"
+- name: Install python custom-requirements
+  pip:
+    name: "{{ item }}"
+    virtualenv: "{{ minos_app_dir }}/venvs/"
+    state: present
+    extra_args: "--exists-action w"
+    version: "{{ minos_edx_server_tools_version }}"
   environment:
     GIT_SSH: "{{ minos_git_ssh }}"
   with_items: