Merge pull request #4208 from edx/youngstrom/update_ec2_plugin

jenkins_common: Update templates for new ec2 version and dependencies

playbooks/roles/jenkins_build/defaults/main.yml

@@ -26,7 +26,7 @@ build_jenkins_plugins_list:
     version: '1.3'
     group: 'org.jenkins-ci.plugins'
   - name: 'script-security'
-    version: '1.27'
+    version: '1.34'
     group: 'org.jenkins-ci.plugins'
   - name: 'mailer'
     version: '1.16'
@@ -50,7 +50,13 @@ build_jenkins_plugins_list:
     version: '1.7'
     group: 'org.jenkins-ci.plugins'
   - name: 'credentials'
-    version: '2.1.8'
+    version: '2.1.16'
+    group: 'org.jenkins-ci.plugins'
+  - name: 'aws-credentials'
+    version: '1.23'
+    group: 'org.jenkins-ci.plugins'
+  - name: 'plain-credentials'
+    version: '1.3'
     group: 'org.jenkins-ci.plugins'
   - name: 'ssh-credentials'
     version: '1.11'
@@ -113,10 +119,10 @@ build_jenkins_plugins_list:
     version: '1.32.1'
     group: 'org.jenkins-ci.plugins'
   - name: 'credentials-binding'
-    version: '1.7'
+    version: '1.13'
     group: 'org.jenkins-ci.plugins'
   - name: 'ec2'
-    version: '1.28'
+    version: '1.37'
     group: 'org.jenkins-ci.plugins'
   - name: 'envinject'
     version: '2.0'
@@ -205,6 +211,9 @@ build_jenkins_plugins_list:
   - name: 'violations'
     version: '0.7.11'
     group: 'org.jenkins-ci.plugins'
+  - name: 'workflow-scm-step'
+    version: '2.4'
+    group: 'org.jenkins-ci.plugins.workflow'
   - name: 'xunit'
     version: '1.93'
     group: 'org.jenkins-ci.plugins'

playbooks/roles/jenkins_common/templates/config/credentials.yml.j2

@@ -49,3 +49,11 @@
   description: '{{ custom_ssh.description }}'
   id: '{{ custom_ssh.id }}'
 {% endfor %}
+{% for aws in JENKINS_AWS_LIST %}
+- credentialType: 'aws'
+  scope: '{{ aws.scope }}'
+  id: '{{ aws.id }}'
+  accessKeyId: '{{ aws.accessKeyId }}'
+  secretAccessKey: '{{ aws.secretAccessKey }}'
+  description: '{{ aws.description }}'
+{% endfor %}

playbooks/roles/jenkins_common/templates/config/ec2_config.yml.j2

 ---
 CLOUDS:
     - NAME: '{{ JENKINS_EC2_REGION }}'
-      ACCESS_KEY_ID: '{{ JENKINS_EC2_ACCESS_KEY_ID }}'
-      SECRET_ACCESS_KEY: '{{ JENKINS_EC2_SECRET_ACCESS_KEY }}'
+      CREDENTIAL_ID: '{{ JENKINS_EC2_CREDENTIAL_ID }}'
       USE_INSTANCE_PROFILE_FOR_CREDS: {{ jenkins_common_use_instance_profile_for_creds }}
       REGION: '{{ JENKINS_EC2_REGION }}'
       EC2_PRIVATE_KEY_PATH: '{{ jenkins_common_config_path }}/ec2/id_rsa'
@@ -18,6 +17,7 @@ CLOUDS:
             REMOTE_FS_ROOT: '{{ ami.REMOTE_FS_ROOT }}'
             SSH_PORT: '{{ ami.SSH_PORT }}'
             INSTANCE_TYPE: '{{ ami.INSTANCE_TYPE }}'
+            EBS_OPTIMIZED: {{ ami.EBS_OPTIMIZED }}
             LABEL_STRING: '{{ ami.LABEL_STRING }}'
             MODE: '{{ ami.MODE }}'
             DESCRIPTION: '{{ ami.DESCRIPTION }}'
@@ -27,6 +27,7 @@ CLOUDS:
             NUM_EXECUTORS: '{{ ami.NUM_EXECUTORS }}'
             REMOTE_ADMIN: '{{ ami.REMOTE_ADMIN }}'
             ROOT_COMMAND_PREFIX: '{{ ami.ROOT_COMMAND_PREFIX }}'
+            SLAVE_COMMAND_PREFIX: '{{ ami.SLAVE_COMMAND_PREFIX }}'
             JVM_OPTIONS: '{{ ami.JVM_OPTIONS }}'
             STOP_ON_TERMINATE: {{ ami.STOP_ON_TERMINATE }}
             SUBNET_ID: '{{ ami.SUBNET_ID }}'