Merge pull request #4062 from edx/jibsheet/dont-swallow-config-errors

Make edx_service stricter about edx_service_config

playbooks/roles/edx_service/defaults/main.yml

@@ -17,6 +17,12 @@
 edx_service_name: edx_service
 
 edx_service_repos: []
+
+# A few roles meta this role but don't need a config file written
+# this allows them to not pass a config and the tasks will skip
+# and not write out a config at all.
+edx_service_config: {}
+
 #
 # OS packages
 #

playbooks/roles/edx_service/tasks/main.yml

@@ -95,7 +95,7 @@
     src: "config.yml.j2"
     dest: "{{ COMMON_CFG_DIR  }}/{{ edx_service_name }}.yml"
     mode: "0644"
-  when: edx_service_config is defined
+  when: edx_service_config
   tags:
     - install
     - install:configuration