Future division is really a capa concern, not a general-purpose codejail concern. Move it.

codejail/safe_exec.py

@@ -28,15 +28,13 @@ def names_and_modules(assumed_imports):
             yield modname, modname
 
 
-def safe_exec(code, globals_dict, locals_dict, future_division=False, assumed_imports=None, files=None, python_path=None):
+def safe_exec(code, globals_dict, locals_dict, assumed_imports=None, files=None, python_path=None):
     """Execute code as "exec" does, but safely.
 
     `code` is a string of Python code.  `globals_dict` and `locals_dict` are
     dictionaries to use as the globals and locals.  Modifications the code
     makes to `locals_dict` are reflected in the dictionary on return.
 
-    `future_division` determines whether Python-3-style division is used.
-
     `assumed_imports` is a list of modules to make available as implicit
     imports for the code.  Entries are either a name, "mod", which makes
     "import mod" part of the code, or a pair, ("f", "fooey"), which makes
@@ -48,9 +46,6 @@ def safe_exec(code, globals_dict, locals_dict, future_division=False, assumed_im
     the_code = []
     files = list(files or ())
 
-    if future_division:
-        the_code.append("from __future__ import division\n")
-
     the_code.append(textwrap.dedent("""\
         import json
         import sys
@@ -90,7 +85,7 @@ def safe_exec(code, globals_dict, locals_dict, future_division=False, assumed_im
     locals_dict.update(json.loads(res.stdout))
 
 
-def not_safe_exec(code, globals_dict, locals_dict, future_division=False, assumed_imports=None, files=None, python_path=None):
+def not_safe_exec(code, globals_dict, locals_dict, assumed_imports=None, files=None, python_path=None):
     """Another implementation of `safe_exec`, but not safe.
 
     This can be swapped in for debugging problems in sandboxed Python code.
@@ -115,9 +110,6 @@ def not_safe_exec(code, globals_dict, locals_dict, future_division=False, assume
                 jd[k] = v
         return json.loads(json.dumps(jd))
 
-    if future_division:
-        code = "from __future__ import division\n" + code
-
     g_dict = straw(globals_dict)
     l_dict = straw(locals_dict)
 

codejail/tests/test_safe_exec.py

@@ -13,15 +13,6 @@ class SafeExecTests(object):
         self.safe_exec("a = 17", g, l)
         self.assertEqual(l['a'], 17)
 
-    def test_division(self):
-        g, l = {}, {}
-        # No future division: 1/2 is 0.
-        self.safe_exec("a = 1/2", g, l)
-        self.assertEqual(l['a'], 0)
-        # Future division: 1/2 is 0.5.
-        self.safe_exec("a = 1/2", g, l, future_division=True)
-        self.assertEqual(l['a'], 0.5)
-
     def test_assumed_imports(self):
         g, l = {}, {}
         # Using string without importing it is bad.