Commit 71f2e4f0 by Matjaz Gregoric

Better use of section element in admin dialog.

Wrapping each tabbed page in a <section> is an appropriate use of the
section element, but separating a single tab into multiple sections is
not.
parent 2e57ec63
...@@ -4,10 +4,12 @@ ...@@ -4,10 +4,12 @@
<div class="xblock--drag-and-drop--editor editor-with-buttons"> <div class="xblock--drag-and-drop--editor editor-with-buttons">
{{ js_templates|safe }} {{ js_templates|safe }}
<section class="drag-builder"> <div class="drag-builder">
<div class="tab feedback-tab"> <section class="tab feedback-tab">
<header class="tab-header">
<section class="tab-content"> <h3>{% trans "Basic Settings" %}</h3>
</header>
<div class="tab-content">
<form class="feedback-form"> <form class="feedback-form">
<label class="h4"> <label class="h4">
<span>{% trans fields.display_name.display_name %}</span> <span>{% trans fields.display_name.display_name %}</span>
...@@ -80,14 +82,14 @@ ...@@ -80,14 +82,14 @@
<textarea class="final-feedback">{{ self.data.feedback.finish }}</textarea> <textarea class="final-feedback">{{ self.data.feedback.finish }}</textarea>
</label> </label>
</form> </form>
</section> </div>
</div> </section>
<div class="tab zones-tab hidden"> <section class="tab zones-tab hidden">
<header class="tab-header"> <header class="tab-header">
<h3>{% trans "Zones" %}</h3> <h3>{% trans "Zones" %}</h3>
</header> </header>
<section class="tab-content"> <div class="tab-content">
<form class="target-image-form"> <form class="target-image-form">
<label class="h4" for="background-url-{{id_suffix}}"> <label class="h4" for="background-url-{{id_suffix}}">
<span>{% trans "Background URL" %}</span> <span>{% trans "Background URL" %}</span>
...@@ -114,8 +116,8 @@ ...@@ -114,8 +116,8 @@
{% endblocktrans %} {% endblocktrans %}
</div> </div>
</form> </form>
</section> </div>
<section class="tab-content"> <div class="tab-content">
<form class="display-labels-form"> <form class="display-labels-form">
<h4>{% trans "Zone labels" %}</h4> <h4>{% trans "Zone labels" %}</h4>
<label class="checkbox-label"> <label class="checkbox-label">
...@@ -130,8 +132,8 @@ ...@@ -130,8 +132,8 @@
<span>{% trans "Display zone borders on the image" %}</span> <span>{% trans "Display zone borders on the image" %}</span>
</label> </label>
</form> </form>
</section> </div>
<section class="tab-content"> <div class="tab-content">
<h4>{% trans "Zone definitions" %}</h4> <h4>{% trans "Zone definitions" %}</h4>
<div class="zone-editor"> <div class="zone-editor">
<div class="controls"> <div class="controls">
...@@ -147,14 +149,14 @@ ...@@ -147,14 +149,14 @@
</div> </div>
</div> </div>
</div> </div>
</section> </div>
</div> </section>
<div class="tab items-tab hidden"> <section class="tab items-tab hidden">
<header class="tab-header"> <header class="tab-header">
<h3>{% trans "Items" %}</h3> <h3>{% trans "Items" %}</h3>
</header> </header>
<section class="tab-content"> <div class="tab-content">
<form class="item-styles-form"> <form class="item-styles-form">
<label class="h4"> <label class="h4">
<span>{% trans fields.item_background_color.display_name %}</span> <span>{% trans fields.item_background_color.display_name %}</span>
...@@ -184,18 +186,18 @@ ...@@ -184,18 +186,18 @@
{% trans fields.max_items_per_zone.help %} {% trans fields.max_items_per_zone.help %}
</div> </div>
</form> </form>
</section> </div>
<section class="tab-content"> <div class="tab-content">
<h4>{% trans "Item definitions" %}</h4> <h4>{% trans "Item definitions" %}</h4>
<form class="items-form"></form> <form class="items-form"></form>
<button class="btn add-item add-element"> <button class="btn add-item add-element">
<span class="icon add" aria-hidden="true"></span> <span class="icon add" aria-hidden="true"></span>
{% trans "Add an item" %} {% trans "Add an item" %}
</button> </button>
</section> </div>
</div> </section>
</section> </div>
<div class="xblock-actions"> <div class="xblock-actions">
<ul class="action-buttons"> <ul class="action-buttons">
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment