Commit 574e1e68 by Jonathan Piacenti

Quality fixup.

parent 0684dd4e
...@@ -380,10 +380,10 @@ class EventsFiredTest(DefaultDataTestMixin, InteractionTestBase, BaseIntegration ...@@ -380,10 +380,10 @@ class EventsFiredTest(DefaultDataTestMixin, InteractionTestBase, BaseIntegration
return "<vertical_demo><drag-and-drop-v2/></vertical_demo>" return "<vertical_demo><drag-and-drop-v2/></vertical_demo>"
def test_loaded(self): def test_loaded(self):
dummy, name, data = self.publish.call_args[0] dummy, name, event_data = self.publish.call_args[0]
self.assertEqual(name, 'edx.drag_and_drop_v2.loaded') self.assertEqual(name, 'edx.drag_and_drop_v2.loaded')
self.assertEqual( self.assertEqual(
data, { event_data, {
'component_id': u'drag-and-drop-v2.drag-and-drop-v2.d0.u0', 'component_id': u'drag-and-drop-v2.drag-and-drop-v2.d0.u0',
'user_id': 'student_1' 'user_id': 'student_1'
} }
...@@ -391,10 +391,10 @@ class EventsFiredTest(DefaultDataTestMixin, InteractionTestBase, BaseIntegration ...@@ -391,10 +391,10 @@ class EventsFiredTest(DefaultDataTestMixin, InteractionTestBase, BaseIntegration
def test_picked_up(self): def test_picked_up(self):
self.parameterized_item_positive_feedback_on_good_move(self.items_map) self.parameterized_item_positive_feedback_on_good_move(self.items_map)
dummy, name, data = self.publish.call_args_list[1][0] dummy, name, event_data = self.publish.call_args_list[1][0]
self.assertEqual(name, 'edx.drag_and_drop_v2.item.picked_up') self.assertEqual(name, 'edx.drag_and_drop_v2.item.picked_up')
self.assertEqual( self.assertEqual(
data, { event_data, {
'component_id': u'drag-and-drop-v2.drag-and-drop-v2.d0.u0', 'component_id': u'drag-and-drop-v2.drag-and-drop-v2.d0.u0',
'user_id': 'student_1', 'user_id': 'student_1',
'item_id': 0, 'item_id': 0,
...@@ -404,10 +404,10 @@ class EventsFiredTest(DefaultDataTestMixin, InteractionTestBase, BaseIntegration ...@@ -404,10 +404,10 @@ class EventsFiredTest(DefaultDataTestMixin, InteractionTestBase, BaseIntegration
def test_dropped(self): def test_dropped(self):
self.parameterized_item_positive_feedback_on_good_move(self.items_map) self.parameterized_item_positive_feedback_on_good_move(self.items_map)
# Skipping to 3, since 2 is grade event. # Skipping to 3, since 2 is grade event.
dummy, name, data = self.publish.call_args_list[3][0] dummy, name, event_data = self.publish.call_args_list[3][0]
self.assertEqual(name, 'edx.drag_and_drop_v2.item.dropped') self.assertEqual(name, 'edx.drag_and_drop_v2.item.dropped')
self.assertEqual( self.assertEqual(
data, { event_data, {
'component_id': u'drag-and-drop-v2.drag-and-drop-v2.d0.u0', 'component_id': u'drag-and-drop-v2.drag-and-drop-v2.d0.u0',
'input': None, 'input': None,
'is_correct': True, 'is_correct': True,
...@@ -420,10 +420,10 @@ class EventsFiredTest(DefaultDataTestMixin, InteractionTestBase, BaseIntegration ...@@ -420,10 +420,10 @@ class EventsFiredTest(DefaultDataTestMixin, InteractionTestBase, BaseIntegration
def test_feedback_opened(self): def test_feedback_opened(self):
self.parameterized_item_positive_feedback_on_good_move(self.items_map) self.parameterized_item_positive_feedback_on_good_move(self.items_map)
dummy, name, data = self.publish.call_args_list[4][0] dummy, name, event_data = self.publish.call_args_list[4][0]
self.assertEqual(name, 'edx.drag_and_drop_v2.feedback.opened') self.assertEqual(name, 'edx.drag_and_drop_v2.feedback.opened')
self.assertEqual( self.assertEqual(
data, { event_data, {
'component_id': u'drag-and-drop-v2.drag-and-drop-v2.d0.u0', 'component_id': u'drag-and-drop-v2.drag-and-drop-v2.d0.u0',
'content': u'Correct! This one belongs to The Top Zone.', 'content': u'Correct! This one belongs to The Top Zone.',
'user_id': 'student_1', 'user_id': 'student_1',
...@@ -433,10 +433,10 @@ class EventsFiredTest(DefaultDataTestMixin, InteractionTestBase, BaseIntegration ...@@ -433,10 +433,10 @@ class EventsFiredTest(DefaultDataTestMixin, InteractionTestBase, BaseIntegration
def test_feedback_closed(self): def test_feedback_closed(self):
self.parameterized_item_positive_feedback_on_good_move(self.items_map) self.parameterized_item_positive_feedback_on_good_move(self.items_map)
dummy, name, data = self.publish.call_args_list[5][0] dummy, name, event_data = self.publish.call_args_list[5][0]
self.assertEqual(name, 'edx.drag_and_drop_v2.feedback.closed') self.assertEqual(name, 'edx.drag_and_drop_v2.feedback.closed')
self.assertEqual( self.assertEqual(
data, { event_data, {
'component_id': u'drag-and-drop-v2.drag-and-drop-v2.d0.u0', 'component_id': u'drag-and-drop-v2.drag-and-drop-v2.d0.u0',
'user_id': 'student_1', 'user_id': 'student_1',
'manually': False, 'manually': False,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment