Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
X
xblock-drag-and-drop-v2
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
OpenEdx
xblock-drag-and-drop-v2
Commits
4f03bd1d
Commit
4f03bd1d
authored
Dec 13, 2016
by
Matjaz Gregoric
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove redundant tabindex attr from buttons.
parent
a798f589
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
5 deletions
+3
-5
drag_and_drop_v2/public/js/drag_and_drop.js
+3
-4
tests/integration/test_render.py
+0
-1
No files found.
drag_and_drop_v2/public/js/drag_and_drop.js
View file @
4f03bd1d
...
@@ -261,7 +261,7 @@ function DragAndDropTemplates(configuration) {
...
@@ -261,7 +261,7 @@ function DragAndDropTemplates(configuration) {
h
(
'div.keyboard-help-dialog'
,
[
h
(
'div.keyboard-help-dialog'
,
[
h
(
'div.modal-window-overlay'
),
h
(
'div.modal-window-overlay'
),
h
(
'div.modal-window'
,
{
attributes
:
{
role
:
'dialog'
,
'aria-labelledby'
:
labelledby_id
,
tabindex
:
-
1
}},
[
h
(
'div.modal-window'
,
{
attributes
:
{
role
:
'dialog'
,
'aria-labelledby'
:
labelledby_id
,
tabindex
:
-
1
}},
[
h
(
'button.modal-dismiss-button.unbutton'
,
{
attributes
:
{
tabindex
:
1
}},
[
h
(
'button.modal-dismiss-button.unbutton'
,
[
h
(
'span.fa.fa-remove'
,
{
attributes
:
{
'aria-hidden'
:
true
}}),
h
(
'span.fa.fa-remove'
,
{
attributes
:
{
'aria-hidden'
:
true
}}),
h
(
'span.sr'
,
gettext
(
'Close'
))
h
(
'span.sr'
,
gettext
(
'Close'
))
]),
]),
...
@@ -321,8 +321,7 @@ function DragAndDropTemplates(configuration) {
...
@@ -321,8 +321,7 @@ function DragAndDropTemplates(configuration) {
'button.unbutton.btn-default.btn-small'
,
'button.unbutton.btn-default.btn-small'
,
{
{
className
:
buttonClass
,
className
:
buttonClass
,
disabled
:
options
.
disabled
||
options
.
spinner
||
false
,
disabled
:
options
.
disabled
||
options
.
spinner
||
false
attributes
:
{
tabindex
:
0
}
},
},
[
[
h
(
"span.btn-icon.fa"
,
{
className
:
iconClass
,
attributes
:
{
"aria-hidden"
:
true
}}),
h
(
"span.btn-icon.fa"
,
{
className
:
iconClass
,
attributes
:
{
"aria-hidden"
:
true
}}),
...
@@ -755,7 +754,7 @@ function DragAndDropBlock(runtime, element, configuration) {
...
@@ -755,7 +754,7 @@ function DragAndDropBlock(runtime, element, configuration) {
};
};
var
focusModalButton
=
function
()
{
var
focusModalButton
=
function
()
{
$root
.
find
(
'.keyboard-help-dialog .modal-dismiss-button
'
).
focus
();
$root
.
find
(
'.keyboard-help-dialog .modal-dismiss-button'
).
focus
();
};
};
var
showKeyboardHelp
=
function
(
evt
)
{
var
showKeyboardHelp
=
function
(
evt
)
{
...
...
tests/integration/test_render.py
View file @
4f03bd1d
...
@@ -217,7 +217,6 @@ class TestDragAndDropRender(BaseIntegrationTest):
...
@@ -217,7 +217,6 @@ class TestDragAndDropRender(BaseIntegrationTest):
self
.
scroll_down
(
250
)
self
.
scroll_down
(
250
)
button
=
self
.
_get_go_to_beginning_button
()
button
=
self
.
_get_go_to_beginning_button
()
self
.
assertEqual
(
button
.
get_attribute
(
'tabindex'
),
'0'
)
# Button is only visible to screen reader users by default.
# Button is only visible to screen reader users by default.
self
.
assertIn
(
'sr'
,
button
.
get_attribute
(
'class'
)
.
split
())
self
.
assertIn
(
'sr'
,
button
.
get_attribute
(
'class'
)
.
split
())
# Set focus to the element (cannot find a way to do this without execute_script).
# Set focus to the element (cannot find a way to do this without execute_script).
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment